8000 HADOOP-18465. Fix S3A SSE test skip when encryption is disabled by dannycjones · Pull Request #4925 · apache/hadoop · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

HADOOP-18465. Fix S3A SSE test skip when encryption is disabled #4925

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Oct 6, 2022
Merged

HADOOP-18465. Fix S3A SSE test skip when encryption is disabled #4925

merged 2 commits into from
Oct 6, 2022

Conversation

dannycjones
Copy link
Contributor
@dannycjones dannycjones commented Sep 22, 2022 •
edited
Loading

Description of PR

When running integration tests against an S3-compatible endpoint without SSE support, tests would fail despite marking test.fs.s3a.encryption.enabled as false.

How was this patch tested?

Against eu-west-1, no special configuration. Encryption enabled.

I see these failures - looks unrelated. Tests for encryption are passing. Third time they went away and everything is passing.

[ERROR] Failures:
[ERROR]   ITestS3AIOStatisticsContext.testThreadSharingIOStatistics:294->assertThreadStatisticsForThread:377 [Bytes read are not as expected for thread : 70] expected:<[150]L> but was:<[85]L>
[ERROR]   ITestS3APrefetchingInputStream.testRandomReadLargeFile:158 [Gauge named stream_read_blocks_in_cache with expected value 2] expected:<[2]L> but was:<[1]L>
[INFO]
[ERROR] Tests run: 1143, Failures: 2, Errors: 0, Skipped: 186

[INFO] Tests run: 3, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 8.451 s - in org.apache.hadoop.fs.s3a.ITestS3AEncryptionSSEKMSDefaultKey

Against an S3-compatible endpoint without SSE support, running only ITestS3AEncryptionSSEKMSDefaultKey.

Works for me :) Only tried ITestS3AEncryptionSSEKMSDefaultKey - there's a lot breaking both before and after this change, still need to figure that bit out later.

For code changes:

  • Does the title or this PR starts with the corresponding JIRA issue id (e.g. 'HADOOP-17799. Your PR title ...')?
  • Object storage: have the integration tests been executed and the endpoint declared according to the connector-specific documentation?
  • If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under ASF 2.0?
  • If applicable, have you updated the LICENSE, LICENSE-binary, NOTICE-binary files?

@dannycjones dannycjones changed the title Fix S3A SSE test skip when encryption is disabled HADOOP-18465. Fix S3A SSE test skip when encryption is disabled Sep 22, 2022
@hadoop-yetus
Copy link

🎊 +1 overall

Vote Subsystem Runtime Logfile Comment
+0 🆗 reexec 1m 20s Docker mode activated.
_ Prechecks _
+1 💚 dupname 0m 0s No case conflicting files found.
+0 🆗 codespell 0m 1s codespell was not available.
+0 🆗 detsecrets 0m 1s detect-secrets was not available.
+1 💚 @author 0m 0s The patch does not contain any @author tags.
+1 💚 test4tests 0m 0s The patch appears to include 1 new or modified test files.
_ trunk Compile Tests _
+1 💚 mvninstall 41m 15s trunk passed
+1 💚 compile 0m 51s trunk passed with JDK Ubuntu-11.0.16+8-post-Ubuntu-0ubuntu120.04
+1 💚 compile 0m 45s trunk passed with JDK Private Build-1.8.0_342-8u342-b07-0ubuntu1~20.04-b07
+1 💚 checkstyle 0m 41s trunk passed
+1 💚 mvnsite 0m 50s trunk passed
+1 💚 javadoc 0m 37s trunk passed with JDK Ubuntu-11.0.16+8-post-Ubuntu-0ubuntu120.04
+1 💚 javadoc 0m 39s trunk passed with JDK Private Build-1.8.0_342-8u342-b07-0ubuntu1~20.04-b07
+1 💚 spotbugs 1m 25s trunk passed
+1 💚 shadedclient 26m 54s branch has no errors when building and testing our client artifacts.
_ Patch Compile Tests _
+1 💚 mvninstall 0m 43s the patch passed
+1 💚 compile 0m 42s the patch passed with JDK Ubuntu-11.0.16+8-post-Ubuntu-0ubuntu120.04
+1 💚 javac 0m 42s the patch passed
+1 💚 compile 0m 33s the patch passed with JDK Private Build-1.8.0_342-8u342-b07-0ubuntu1~20.04-b07
+1 💚 javac 0m 33s the patch passed
+1 💚 blanks 0m 0s The patch has no blanks issues.
+1 💚 checkstyle 0m 23s the patch passed
+1 💚 mvnsite 0m 38s the patch passed
+1 💚 javadoc 0m 20s the patch passed with JDK Ubuntu-11.0.16+8-post-Ubuntu-0ubuntu120.04
+1 💚 javadoc 0m 27s the patch passed with JDK Private Build-1.8.0_342-8u342-b07-0ubuntu1~20.04-b07
+1 💚 spotbugs 1m 16s the patch passed
+1 💚 shadedclient 24m 11s patch has no errors when building and testing our client artifacts.
_ Other Tests _
+1 💚 unit 2m 41s hadoop-aws in the patch passed.
+1 💚 asflicense 0m 43s The patch does not generate ASF License warnings.
108m 52s
Subsystem Report/Notes
Docker ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-4925/1/artifact/out/Dockerfile
GITHUB PR #4925
Optional Tests dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient spotbugs checkstyle codespell detsecrets
uname Linux 8504ec32468f 4.15.0-191-generic #202-Ubuntu SMP Thu Aug 4 01:49:29 UTC 2022 x86_64 x86_64 x86_64 GNU/Linux
Build tool maven
Personality dev-support/bin/hadoop.sh
git revision trunk / 94a2b0a
Default Java Private Build-1.8.0_342-8u342-b07-0ubuntu1~20.04-b07
Multi-JDK versions /usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-11.0.16+8-post-Ubuntu-0ubuntu120.04 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_342-8u342-b07-0ubuntu1~20.04-b07
Test Results https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-4925/1/testReport/
Max. process+thread count 562 (vs. ulimit of 5500)
modules C: hadoop-tools/hadoop-aws U: hadoop-tools/hadoop-aws
Console output https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-4925/1/console
versions git=2.25.1 maven=3.6.3 spotbugs=4.2.2
Powered by Apache Yetus 0.14.0 https://yetus.apache.org

This message was automatically generated.

@dannycjones dannycjones marked this pull request as ready for review September 23, 2022 08:56
@hadoop-yetus
Copy link

🎊 +1 overall

Vote Subsystem Runtime Logfile Comment
+0 🆗 reexec 0m 59s Docker mode activated.
_ Prechecks _
+1 💚 dupname 0m 0s No case conflicting files found.
+0 🆗 codespell 0m 0s codespell was not available.
+0 🆗 detsecrets 0m 0s detect-secrets was not available.
+1 💚 @author 0m 0s The patch does not contain any @author tags.
+1 💚 test4tests 0m 0s The patch appears to include 1 new or modified test files.
_ trunk Compile Tests _
+1 💚 mvninstall 42m 25s trunk passed
+1 💚 compile 0m 50s trunk passed with JDK Ubuntu-11.0.16+8-post-Ubuntu-0ubuntu120.04
+1 💚 compile 0m 42s trunk passed with JDK Private Build-1.8.0_342-8u342-b07-0ubuntu1~20.04-b07
+1 💚 checkstyle 0m 39s trunk passed
+1 💚 mvnsite 0m 49s trunk passed
+1 💚 javadoc 0m 35s trunk passed with JDK Ubuntu-11.0.16+8-post-Ubuntu-0ubuntu120.04
+1 💚 javadoc 0m 36s trunk passed with JDK Private Build-1.8.0_342-8u342-b07-0ubuntu1~20.04-b07
+1 💚 spotbugs 1m 25s trunk passed
+1 💚 shadedclient 23m 51s branch has no errors when building and testing our client artifacts.
_ Patch Compile Tests _
+1 💚 mvninstall 0m 35s the patch passed
+1 💚 compile 0m 43s the patch passed with JDK Ubuntu-11.0.16+8-post-Ubuntu-0ubuntu120.04
+1 💚 javac 0m 43s the patch passed
+1 💚 compile 0m 32s the patch passed with JDK Private Build-1.8.0_342-8u342-b07-0ubuntu1~20.04-b07
+1 💚 javac 0m 32s the patch passed
+1 💚 blanks 0m 0s The patch has no blanks issues.
+1 💚 checkstyle 0m 22s the patch passed
+1 💚 mvnsite 0m 37s the patch passed
+1 💚 javadoc 0m 18s the patch passed with JDK Ubuntu-11.0.16+8-post-Ubuntu-0ubuntu120.04
+1 💚 javadoc 0m 25s the patch passed with JDK Private Build-1.8.0_342-8u342-b07-0ubuntu1~20.04-b07
+1 💚 spotbugs 1m 12s the patch passed
+1 💚 shadedclient 23m 30s patch has no errors when building and testing our client artifacts.
_ Other Tests _
+1 💚 unit 2m 36s hadoop-aws in the patch passed.
+1 💚 asflicense 0m 40s The patch does not generate ASF License warnings.
105m 4s
Subsystem Report/Notes
Docker ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-4925/2/artifact/out/Dockerfile
GITHUB PR #4925
Optional Tests dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient spotbugs checkstyle codespell detsecrets
uname Linux 09eefe33415c 4.15.0-191-generic #202-Ubuntu SMP Thu Aug 4 01:49:29 UTC 2022 x86_64 x86_64 x86_64 GNU/Linux
Build tool maven
Personality dev-support/bin/hadoop.sh
git revision trunk / 1673c74
Default Java Private Build-1.8.0_342-8u342-b07-0ubuntu1~20.04-b07
Multi-JDK versions /usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-11.0.16+8-post-Ubuntu-0ubuntu120.04 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_342-8u342-b07-0ubuntu1~20.04-b07
Test Results https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-4925/2/testReport/
Max. process+thread count 534 (vs. ulimit of 5500)
modules C: hadoop-tools/hadoop-aws U: hadoop-tools/hadoop-aws
Console output https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-4925/2/console
versions git=2.25.1 maven=3.6.3 spotbugs=4.2.2
Powered by Apache Yetus 0.14.0 https://yetus.apache.org

This message was automatically generated.

steveloughran
steveloughran approved these changes Oct 6, 2022
View reviewed changes
Copy link
Contributor
@steveloughran steveloughran left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

hadoop-tools/hadoop-aws/src/test/java/org/apache/hadoop/fs/s3a/AbstractTestS3AEncryption.java
/**
* Skips the tests if encryption is not enabled in configuration.
*
* @implNote We can use {@link #createConfiguration()} here since
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

not sure if maven is set up to use those tags; no reason why we shouldn't start though

Copy link
Contributor Author
@dannycjones 8000 dannycjones Oct 6, 2022 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I never realised they weren't JavaDoc standard tags. I think they're just used with JDK docs.

I'm not really fussed either way, I can move to an inline comment really.

Just as a note, if this was in public src code then I think builds would fail with something like this:

[ERROR] hadoop/hadoop-tools/hadoop-aws/src/main/java/org/apache/hadoop/fs/s3a/audit/impl/LoggingAuditor.java:61: error: unknown tag: myTag
[ERROR]  * @myTag What happens if I build this?

Happy to move it to inline comment in trunk - let me know.

@steveloughran steveloughran merged commit 7ec762a into apache:trunk Oct 6, 2022
@steveloughran
Copy link
Contributor

ok, merged to trunk. this can go into -3.3 as well, can't it?

dannycjones added a commit to dannycjones/hadoop that referenced this pull request Oct 6, 2022
@dannycjones
HADOOP-18465. Fix S3A SSE test skip when encryption is disabled (apac…
0c1fb26 
…he#4925)


Contributed by Daniel Carl Jones
@dannycjones dannycjones mentioned this pull request Oct 6, 2022
Merged
4 tasks
@dannycjones dannycjones deleted the HADOOP-18465-fix-sse-skip-on-disabled-encryption branch October 6, 2022 13:25
@dannycjones
Copy link
Contributor Author

ok, merged to trunk. this can go into -3.3 as well, can't it?

Yeah, I don't see why not. I've opened #4977. Integ tests are running ATM.

steveloughran pushed a commit that referenced this pull request Oct 19, 2022
@dannycjones
HADOOP-18465. Fix S3A SSE test skip when encryption is disabled (#4925)
2778bc8 
Contributed by Daniel Carl Jones
asfgit pushed a commit that referenced this pull request Oct 19, 2022
@dannycjones @steveloughran
HADOOP-18465. Fix S3A SSE test skip when encryption is disabled (#4925)
1798677 
Contributed by Daniel Carl Jones
HarshitGupta11 pushed a commit to HarshitGupta11/hadoop that referenced this pull request Nov 28, 2022
@dannycjones
HADOOP-18465. Fix S3A SSE test skip when encryption is disabled (apac…
dfdd1ae 
…he#4925)


Contributed by Daniel Carl Jones
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@steveloughran steveloughran steveloughran approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@dannycjones @hadoop-yetus @steveloughran
0