HADOOP-18653. LogLevel servlet to determine log impl before using setLevel #5456
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@steveloughran This PR is a follow-up task from #5315 (comment here) Could you please review this PR? For the error case, it's difficult to write any UT as we can't remove slf4j-log4j jar from classpath for a given test. |
|
@Apache9 @jojochuang could you please also take a look? |
|
🎊 +1 overall
This message was automatically generated. |
steveloughran
requested changes
Mar 8, 2023
| if (GenericsUtil.isLog4jLogger(logName)) { | ||
| process(Logger.getLogger(logName), level, out); | ||
| } else { | ||
| out.println("Sorry, " + log.getClass() + " not supported.<br />"); |
There was a problem hiding this comment.
text to explain "log4j loggers only"
| @@ -89,10 +89,30 @@ public static boolean isLog4jLogger(Class<?> clazz) { | |||
| } | |||
| Logger log = LoggerFactory.getLogger(clazz); | |||
| try { | |||
| Class log4jClass = Class.forName("org.slf4j.impl.Log4jLoggerAdapter"); | |||
| Class<?> log4jClass = Class.forName("org.slf4j.impl.Log4jLoggerAdapter"); | |||
There was a problem hiding this comment.
make this a constant string and use everyw 8000 here it is needed
| } | ||
| Logger log = LoggerFactory.getLogger(logger); | ||
| try { | ||
| Class<?> log4jClass = Class.forName("org.slf4j.impl.Log4jLoggerAdapter"); |
There was a problem hiding this comment.
if the class isn't found, then that fact can be remembered in an atomic boolean so future loads/checks skipped.
|
🎊 +1 overall
This message was automatically generated. |
steveloughran
requested changes
Mar 10, 2023
| @@ -103,14 +113,15 @@ public static boolean isLog4jLogger(Class<?> clazz) { | |||
| * @return true if the logger uses Log4J implementation. | |||
| */ | |||
| public static boolean isLog4jLogger(String logger) { | |||
| if (logger == null) { | |||
| if (logger == null || !IS_LOG4J_LOGGER.get()) { | |||
| return false; | |||
| } | |||
| Logger log = LoggerFactory.getLogger(logger); | |||
| try { | |||
There was a problem hiding this comment.
this try/catch is a duplicate of isLog4jLogger(class).
why not do isLog4jLogger(LoggerFactory.getLogger(logger))
There was a problem hiding this comment.
I think the other way around would be more appropriate?
For instance, in slf4j implementation, they have:
public static Logger getLogger(Class<?> clazz) {
Logger logger = getLogger(clazz.getName());
...
...
Hence, we can also call clazz.getName() here.
There was a problem hiding this comment.
Refactored to keep the logic in only one utility method. The other method will just call this one. Simplified (exactly as slf4j library methods).
|
🎊 +1 overall
This message was automatically generated. |
|
🎊 +1 overall
This message was automatically generated. |
ferdelyi
pushed a commit
to ferdelyi/hadoop
that referenced
this pull request
May 26, 2023
…Level (apache#5456) The log level can only be set on Log4J log implementations; probes are used to downgrade to a warning when other logging back ends are used Contributed by Viraj Jasani
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
LogLevel GET API is used to set log level for a given class name dynamically. While we have cleaned up the commons-logging references, it would be great to determine whether slf4j log4j adapter is in the classpath before allowing client to set the log level.
Proposed changes: