8000 HADOOP-18661. Fix bin/hadoop usage script terminology. by steveloughran · Pull Request #5473 · apache/hadoop · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

HADOOP-18661. Fix bin/hadoop usage script terminology. #5473

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 13, 2023
Merged

HADOOP-18661. Fix bin/hadoop usage script terminology. #5473

merged 1 commit into from
Mar 13, 2023

Conversation

steveloughran
Copy link
Contributor

Description of PR

Emergency followup to HADOOP-13209 before we cut RC3: s/slaves/r/workers in the usage message you get when you type "bin/hadoop"

Noticed while playing with the RC2 and needed to get in before I kick off RC3 on sunday.

pushing though github for due diligence

How was this patch tested?

For code changes:

  • Does the title or this PR starts with the corresponding JIRA issue id (e.g. 'HADOOP-17799. Your PR title ...')?
  • Object storage: have the integration tests been executed and the endpoint declared according to the connector-specific documentation?
  • If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under ASF 2.0?
  • If applicable, have you updated the LICENSE, LICENSE-binary, NOTICE-binary files?

@steveloughran
HADOOP-18470. Fix bin/hadoop usage script terminology.
1bf18d9 
Emergency followup to HADOOP-13209 before we cut RC3: s/slaves/r/workers in
the usage message you get when you type "bin/hadoop"

Change-Id: Ifa9691dd14c261eedfe7aa9c41324720f3a69d0a
@hadoop-yetus
Copy link

💔 -1 overall

Vote Subsystem Runtime Logfile Comment
+0 🆗 reexec 7m 9s Docker mode activated.
_ Prechecks _
+1 💚 dupname 0m 0s No case conflicting files found.
+0 🆗 codespell 0m 0s codespell was not available.
+0 🆗 detsecrets 0m 0s detect-secrets was not available.
+0 🆗 shelldocs 0m 0s Shelldocs was not available.
+1 💚 @author 0m 0s The patch does not contain any @author tags.
-1 ❌ test4tests 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
_ branch-3.3.5 Compile Tests _
+1 💚 mvninstall 36m 8s branch-3.3.5 passed
+1 💚 mvnsite 1m 21s branch-3.3.5 passed
+1 💚 shadedclient 22m 31s branch has no errors when building and testing our client artifacts.
_ Patch Compile Tests _
+1 💚 mvninstall 0m 54s the patch passed
+1 💚 blanks 0m 0s The patch has no blanks issues.
+1 💚 mvnsite 1m 11s the patch passed
+1 💚 shellcheck 0m 10s No new issues.
+1 💚 shadedclient 22m 22s patch has no errors when building and testing our client artifacts.
_ Other Tests _
+1 💚 unit 3m 6s hadoop-common in the patch passed.
+1 💚 asflicense 0m 38s The patch does not generate ASF License warnings.
97m 56s
Subsystem Report/Notes
Docker ClientAPI=1.42 ServerAPI=1.42 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-5473/1/artifact/out/Dockerfile
GITHUB PR #5473
Optional Tests dupname asflicense mvnsite unit codespell detsecrets shellcheck shelldocs
uname Linux 401e49d51bbd 4.15.0-206-generic #217-Ubuntu SMP Fri Feb 3 19:10:13 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux
Build tool maven
Personality dev-support/bin/hadoop.sh
git revision branch-3.3.5 / 1bf18d9
Test Results https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-5473/1/testReport/
Max. process+thread count 555 (vs. ulimit of 5500)
modules C: hadoop-common-project/hadoop-common U: hadoop-common-project/hadoop-common
Console output https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-5473/1/console
versions git=2.17.1 maven=3.6.0 shellcheck=0.4.6
Powered by Apache Yetus 0.14.0 https://yetus.apache.org

This message was automatically generated.

ayushtkn
ayushtkn approved these changes Mar 13, 2023
View reviewed changes
Copy link
Member
@ayushtkn ayushtkn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This change is valid for trunk as well and sounds very reasonable to me. Should consider creating a separate ticket and push to all active lines.

Changes LGTM

@steveloughran
Copy link
Contributor Author

@ayushtkn will do; just getting it into this one and then moving up, as this is the release to come out today

@steveloughran steveloughran changed the title HADOOP-18470. Fix bin/hadoop usage script terminology. HADOOP-18661. Fix bin/hadoop usage script terminology. Mar 13, 2023
@steveloughran
Copy link
Contributor Author

+created explicit jira rather than than using the 3.3.5 release id, for better tracking

@steveloughran steveloughran merged commit 706d882 into apache:branch-3.3.5 Mar 13, 2023
asfgit pushed a commit that referenced this pull request Mar 13, 2023
@steveloughran
HADOOP-18661. Fix bin/hadoop usage script terminology. (#5473)
0dd4e50 
Followup to HADOOP-13209: s/slaves/r/workers in
the usage message you get when you type "bin/hadoop"

Contributed by Steve Loughran
asfgit pushed a commit that referenced this pull request Mar 13, 2023
@steveloughran
HADOOP-18661. Fix bin/hadoop usage script terminology. (#5473)
09469bf 
Followup to HADOOP-13209: s/slaves/r/workers in
the usage message you get when you type "bin/hadoop"

Contributed by Steve Loughran
ferdelyi pushed a commit to ferdelyi/hadoop that referenced this pull request May 26, 2023
@steveloughran @ferdelyi
HADOOP-18661. Fix bin/hadoop usage script terminology. (apache#5473)
d4d3077 
Followup to HADOOP-13209: s/slaves/r/workers in
the usage message you get when you type "bin/hadoop"

Contributed by Steve Loughran
6381
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ayushtkn ayushtkn ayushtkn approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@steveloughran @hadoop-yetus @ayushtkn
0