8000 HADOOP-18763. Upgrade aws-java-sdk to 1.12.367 by virajjasani · Pull Request #5741 · apache/hadoop · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

HADOOP-18763. Upgrade aws-java-sdk to 1.12.367 #5741

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 14, 2023
Merged

HADOOP-18763. Upgrade aws-java-sdk to 1.12.367 #5741

merged 1 commit into from
Jun 14, 2023

Conversation

virajjasani
Copy link
Contributor
@virajjasani virajjasani commented Jun 12, 2023 •
edited
Loading

Jira: HADOOP-18763

netty version used by aws-sdk-java 1.12.367 is 4.1.86.Final
https://github.com/aws/aws-sdk-java/blob/1.12.367/pom.xml#L409-L410

@virajjasani
Copy link
Contributor Author
virajjasani commented Jun 12, 2023 •
edited
Loading

us-west-2:

two rounds of testing for each of the commands, results look good (details on Jira)

$ mvn clean verify -Dparallel-tests -DtestsThreadCount=8 -Dscale -Dprefetch

$ mvn clean verify -Dparallel-tests -DtestsThreadCount=8 -Dscale

@virajjasani
Copy link
Contributor Author

netty version: 4.1.86.Final
https://github.com/aws/aws-sdk-java/blob/1.12.367/pom.xml#L409-L410

@jojochuang jojochuang requested a review from steveloughran June 13, 2023 00:34
@jojochuang
Copy link
Contributor

Just from a code and functionality perspective LGTM.
But folks like @steveloughran or @mukund-thakur or someone else more familiar with S3A need to chime in too.

@hadoop-yetus
Copy link

💔 -1 overall

Vote Subsystem Runtime Logfile Comment
+0 🆗 reexec 0m 52s Docker mode activated.
_ Prechecks _
+1 💚 dupname 0m 0s No case conflicting files found.
+0 🆗 codespell 0m 1s codespell was not available.
+0 🆗 detsecrets 0m 1s detect-secrets was not available.
+0 🆗 xmllint 0m 1s xmllint was not available.
+0 🆗 shelldocs 0m 1s Shelldocs was not available.
+1 💚 @author 0m 0s The patch does not contain any @author tags.
-1 ❌ test4tests 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
_ trunk Compile Tests _
+0 🆗 mvndep 21m 4s Maven dependency ordering for branch
+1 💚 mvninstall 23m 47s trunk passed
+1 💚 compile 18m 37s trunk passed with JDK Ubuntu-11.0.19+7-post-Ubuntu-0ubuntu120.04.1
+1 💚 compile 17m 0s trunk passed with JDK Private Build-1.8.0_362-8u372-gaus1-0ubuntu120.04-b09
+1 💚 mvnsite 21m 36s trunk passed
+1 💚 javadoc 9m 4s trunk passed with JDK Ubuntu-11.0.19+7-post-Ubuntu-0ubuntu120.04.1
+1 💚 javadoc 7m 27s trunk passed with JDK Private Build-1.8.0_362-8u372-gaus1-0ubuntu120.04-b09
+1 💚 shadedclient 40m 0s branch has no errors when building and testing our client artifacts.
_ Patch Compile Tests _
+0 🆗 mvndep 0m 45s Maven dependency ordering for patch
+1 💚 mvninstall 20m 33s the patch passed
+1 💚 compile 17m 57s the patch passed with JDK Ubuntu-11.0.19+7-post-Ubuntu-0ubuntu120.04.1
+1 💚 javac 17m 57s the patch passed
+1 💚 compile 16m 58s the patch passed with JDK Private Build-1.8.0_362-8u372-gaus1-0ubuntu120.04-b09
+1 💚 javac 16m 58s the patch passed
+1 💚 blanks 0m 0s The patch has no blanks issues.
+1 💚 mvnsite 15m 10s the patch passed
+1 💚 shellcheck 0m 0s No new issues.
+1 💚 javadoc 8m 44s the patch passed with JDK Ubuntu-11.0.19+7-post-Ubuntu-0ubuntu120.04.1
+1 💚 javadoc 7m 33s the patch passed with JDK Private Build-1.8.0_362-8u372-gaus1-0ubuntu120.04-b09
+1 💚 shadedclient 41m 9s patch has no errors when building and testing our client artifacts.
_ Other Tests _
-1 ❌ unit 797m 20s /patch-unit-root.txt root in the patch passed.
-1 ❌ asflicense 1m 39s /results-asflicense.txt The patch generated 1 ASF License warnings.
1059m 40s
Reason Tests
Failed junit tests hadoop.mapreduce.v2.TestMRJobsWithProfiler
hadoop.mapreduce.v2.TestMRJobs
hadoop.mapreduce.v2.TestUberAM
hadoop.yarn.server.timelineservice.security.TestTimelineAuthFilterForV2
hadoop.yarn.client.TestFederationRMFailoverProxyProvider
hadoop.hdfs.server.namenode.ha.TestObserverNode
Subsystem Report/Notes
Docker ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-5741/1/artifact/out/Dockerfile
GITHUB PR #5741
Optional Tests dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient codespell detsecrets xmllint shellcheck shelldocs
uname Linux e044c9d5c3d7 4.15.0-206-generic #217-Ubuntu SMP Fri Feb 3 19:10:13 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux
Build tool maven
Personality dev-support/bin/hadoop.sh
git revision trunk / 9c74550
Default Java Private Build-1.8.0_362-8u372-gaus1-0ubuntu120.04-b09
Multi-JDK versions /usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-11.0.19+7-post-Ubuntu-0ubuntu120.04.1 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_362-8u372-gaus1-0ubuntu120.04-b09
Test Results https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-5741/1/testReport/
Max. process+thread count 3098 (vs. ulimit of 5500)
modules C: hadoop-project . U: .
Console output https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-5741/1/console
versions git=2.25.1 maven=3.6.3 shellcheck=0.7.0
Powered by Apache Yetus 0.14.0 https://yetus.apache.org

This message was automatically generated.

@mukund-thakur
Copy link
Contributor

Was going through the comments on Jira. Looking good. Will run some tests myself.

@virajjasani Some unit tests are failing in Yetus. Need to check those.

This license issue seems unrelated to me
hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager/yarnfederation/application_123456_0001/SC-1/_record:1:Missing Apache License

@jojochuang
Copy link
Contributor

Those failed tests don't rely on awsk sdk so can be ignored.

@virajjasani
Copy link
Contributor Author

Was going through the comments on Jira. Looking good. Will run some tests myself.

@virajjasani Some unit tests are failing in Yetus. Need to check those.

This license issue seems unrelated to me hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager/yarnfederation/application_123456_0001/SC-1/_record:1:Missing Apache License

yes sir, thanks for taking a look. i just confirmed that test majority failures are not relevant by comparing with various results from https://ci-hadoop.apache.org/view/Hadoop/job/hadoop-qbt-trunk-java8-linux-x86_64

i was aware of mapreduce test failures as they appear all the time. moreover, TestObserverNode also seems to be appearing on some of the daily build results (hadoop-qbt-trunk-java8-linux-x86_64).

@virajjasani
Copy link
Contributor Author
virajjasani commented Jun 13, 2023 •
edited
Loading

what i am not aware of is the failure on TestFederationRMFailoverProxyProvider, and also the asf warning.

@goiri @slfan1989 could you please once take a look in case you are aware of them (just to make sure we can finally ignore them for this PR)

@virajjasani
Copy link
Contributor Author

Those failed tests don't rely on awsk sdk so can be ignored.

agree, i will re-run the whole test suit against us-west-2 again today.

@virajjasani
Copy link
Contributor Author

another round looks good:
mvn clean verify -Dparallel-tests -DtestsThreadCount=8 -Dscale -Dprefetch

@mukund-thakur
Copy link
Contributor

Running through most of the steps myself. Looking good.
Just assumed role and access point tests are pending.

mukund-thakur
mukund-thakur approved these changes Jun 14, 2023
View reviewed changes
Copy link
Contributor
@mukund-thakur mukund-thakur left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM +1,
Ran other tests as well.

@mukund-thakur mukund-thakur merged commit 2fe3b2a into apache:trunk Jun 14, 2023
@jojochuang
Copy link
Contributor

Can we simply cherrypick this change into branch-3.3 or we need to do another round of testing?

@mukund-thakur
Copy link
Contributor
mukund-thakur commented Jun 14, 2023 •
edited
Loading

I am just doing that. Another round of testing not required. Just a full compilation is fine.

mukund-thakur pushed a commit that referenced this pull request Jun 14, 2023
@virajjasani @mukund-thakur
HADOOP-18763. Upgrade aws-java-sdk to 1.12.367 (#5741)
4f6ebab 
Contributed By: Viraj Jasani
 Conflicts:
	LICENSE-binary
@mukund-thakur
Copy link
Contributor

cp'ed locally, recompiled, and pushed to branch-3.3

asfgit pushed a commit that referenced this pull request Jun 14, 2023
@virajjasani @jojochuang
HADOOP-18763. Upgrade aws-java-sdk to 1.12.367 (#5741)
a756d39 
Contributed By: Viraj Jasani
 Conflicts:
	LICENSE-binary

(cherry picked from commit 4f6ebab)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mukund-thakur mukund-thakur mukund-thakur approved these changes

@steveloughran steveloughran Awaiting requested review from steveloughran

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@virajjasani @jojochuang @hadoop-yetus @mukund-thakur
0