-
Notifications
You must be signed in to change notification settings - Fork 9k
YARN-11498 backport jettison exclusions #6063
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
YARN-11498 backport jettison exclusions #6063
Conversation
💔 -1 overall
This message was automatically generated. |
💔 -1 overall
This message was automatically generated. |
💔 -1 overall
This message was automatically generated. |
any suggestions as to why the client is reported as a failure? the console output doesn't highlight any problems |
8075d6b
to
1c918c7
Compare
TestFSConfigToCSConfigConverterMain crashed in the last run. I've restarted the build to see if it was a one-off. |
💔 -1 overall
This message was automatically generated. |
I'm running into issues with stray module-info.class files in hadoop-client-runtime and hadoop-client-minicluster after shading. This is also happening in #6101 and I am concentrating on fixing it there. |
your diligence is appreciated. tracking the other PR |
This test is still crashing - an OutOfMemory/Thread issue last time out - https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-6063/4/artifact/out/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager.txt java.lang.OutOfMemoryError: unable to create new native thread |
💔 -1 overall
This message was automatically generated. |
6a3b47a
to
1431f25
Compare
💔 -1 overall
This message was automatically generated. |
💔 -1 overall
This message was automatically generated. |
this has been in for a while. why not rebase and retry? |
4d6e780
to
9fd4f78
Compare
@steveloughran I've done a rebase, let's see what happens with this build. |
💔 -1 overall
This message was automatically generated. |
The build issue is this:
I'm not yet sure why this happens in branch-3.3 but not in trunk. |
In trunk, hadoop-client-runtime does not have the jettison classes. |
💔 -1 overall
This message was automatically generated. |
…ed (apache#5786) All uses of jersey-json in the yarn and other hadoop modules now exclude the obsolete org.codehaus.jettison/jettison and so avoid all security issues which can come from the library. Contributed by PJ Fanning extra exclusion add jettison to hadoop-common (trunk branch has this) build issue undo exclusion
f3ecc9a
to
66cede4
Compare
💔 -1 overall
This message was automatically generated. |
@steveloughran @ayushtkn @slfan1989 do you think that is ok to merge? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
+1
Description of PR
backport #5623 and #5786
How was this patch tested?
CI build