-
Notifications
You must be signed in to change notification settings - Fork 9k
HDFS-17594. [ARR] RouterCacheAdmin supports asynchronous rpc. #6986
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
💔 -1 overall
This message was automatically generated. |
public long addCacheDirective( | ||
CacheDirectiveInfo path, EnumSet<CacheFlag> flags) throws IOException { | ||
invokeAddCacheDirective(path, flags); | ||
asyncApply((ApplyFunction<Map<RemoteLocation, Long>, Long>) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Archie-wang Thanks for your contribution, you can remove the blank at the end of this line of code.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
done
🎊 +1 overall
This message was automatically generated. |
4e0b405
to
a591902
Compare
Hi, @Archie-wang HDFS-17545 has already been merged into HDFS-17531, please rebase your development branch using HDFS-17531. |
aeecad6
to
9d8f287
Compare
💔 -1 overall
This message was automatically generated. |
9d8f287
to
7c1ceda
Compare
🎊 +1 overall
This message was automatically generated.
KeeProMise
approved these changes
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. @Archie-wang LGTM, @Hexiaoqiao if you have time, please take a look at the PR.
Hexiaoqiao
approved these changes
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. LGTM. +1.
KeeProMise
pushed a commit
to KeeProMise/hadoop
that referenced
this pull request
…#6986). Contributed by Archie73. Reviewed-by: Jian Zhang <keepromise@apache.org> Signed-off-by: He Xiaoqiao <hexiaoqiao@apache.org>
KeeProMise
pushed a commit
to KeeProMise/hadoop
that referenced
this pull request
…#6986). Contributed by Archie73. Reviewed-by: Jian Zhang <keepromise@apache.org> Signed-off-by: He Xiaoqiao <hexiaoqiao@apache.org>
KeeProMise
pushed a commit
to KeeProMise/hadoop
that referenced
this pull request
…#6986). Contributed by Archie73. Reviewed-by: Jian Zhang <keepromise@apache.org> Signed-off-by: He Xiaoqiao <hexiaoqiao@apache.org>
KeeProMise
pushed a commit
to KeeProMise/hadoop
that referenced
this pull request
…#6986). Contributed by Archie73. Reviewed-by: Jian Zhang <keepromise@apache.org> Signed-off-by: He Xiaoqiao <hexiaoqiao@apache.org>
4 tasks
KeeProMise
pushed a commit
to KeeProMise/hadoop
that referenced
this pull request
…#6986). Contributed by Archie73. Reviewed-by: Jian Zhang <keepromise@apache.org> Signed-off-by: He Xiaoqiao <hexiaoqiao@apache.org>
KeeProMise
pushed a commit
that referenced
this pull request
…. Contributed by Archie73. Reviewed-by: Jian Zhang <keepromise@apache.org> Signed-off-by: He Xiaoqiao <hexiaoqiao@apache.org>
KeeProMise
pushed a commit
to KeeProMise/hadoop
that referenced
this pull request
…#6986). Contributed by Archie73. Reviewed-by: Jian Zhang <keepromise@apache.org> Signed-off-by: He Xiaoqiao <hexiaoqiao@apache.org>
KeeProMise
pushed a commit
to KeeProMise/hadoop
that referenced
this pull request
…#6986). Contributed by Archie73. Reviewed-by: Jian Zhang <keepromise@apache.org> Signed-off-by: He Xiaoqiao <hexiaoqiao@apache.org>
Hexiaoqiao
pushed a commit
to Hexiaoqiao/hadoop
that referenced
this pull request
…#6986). Contributed by Archie73. Reviewed-by: Jian Zhang <keepromise@apache.org> Signed-off-by: He Xiaoqiao <hexiaoqiao@apache.org>
adideshpande
pushed a commit
to adideshpande/hadoop
that referenced
this pull request
…#6986). Contributed by Archie73. Reviewed-by: Jian Zhang <keepromise@apache.org> Signed-off-by: He Xiaoqiao <hexiaoqiao@apache.org>
YanivKunda
pushed a commit
to YanivKunda/hadoop
that referenced
this pull request
…#6986). Contributed by Archie73. Reviewed-by: Jian Zhang <keepromise@apache.org> Signed-off-by: He Xiaoqiao <hexiaoqiao@apache.org>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
You can’t perform that action at this time.
|
Description of PR
https://issues.apache.org/jira/browse/HDFS-17594
How was this patch tested?
new UT
TestRouterAsyncCacheAdmin
For code changes:
LICENSE
,LICENSE-binary
,NOTICE-binary
files?