HDFS-17595. [ARR] ErasureCoding supports asynchronous rpc. #6983
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
f2814d8 to
058c751
Compare
KeeProMise
reviewed
Aug 6, 2024
Comment on lines
64
to
69
| // Map<FederationNamespaceInfo, ErasureCodingPolicyInfo[]> ret = | ||
| rpcClient.invokeConcurrent( | ||
| nss, method, true, false, ErasureCodingPolicyInfo[].class); | ||
| asyncApply((ApplyFunction<Map<FederationNamespaceInfo, ErasureCodingPolicyInfo[]>, ErasureCodingPolicyInfo[]>) ret -> { | ||
| return merge(ret, ErasureCodingPolicyInfo.class); | ||
| }); | ||
|
|
There was a problem hiding this comment.
Thank you for your contribution. You can delete the comment there and pay attention to the length of the line.
There was a problem hiding this comment.
Sir, thanks for reviewing. have fixed.
Comment on lines
151
to
160
| // Map<FederationNamespaceInfo, ECTopologyVerifierResult> ret | ||
| rpcClient.invokeConcurrent(nss, method, true, false, | ||
| ECTopologyVerifierResult.class); | ||
| asyncApply((ApplyFunction<Map<FederationNamespaceInfo, ECTopologyVerifierResult>, ECTopologyVerifierResult>) ret -> { | ||
| for (Map.Entry<FederationNamespaceInfo, ECTopologyVerifierResult> entry : ret | ||
| .entrySet()) { | ||
| if (!entry.getValue().isSupported()) { | ||
| return entry.getValue(); | ||
| } | ||
| } | ||
| // If no negative result, return the result from the first namespace. | ||
| return ret.get(nss.iterator().next()); | ||
| }); |
|
Hi @hfutatzhanghb, Thanks for your contribution, you can add a UT for testing AsyncErasureCoding. |
OK, will add UTs these days. |
4 tasks
4e0b405 to
a591902
Compare
|
Hi, @hfutatzhanghb HDFS-17545 has already been merged into HDFS-17531, please rebase your development branch using HDFS-17531. |
6d6f9c7 to
60bc890
Compare
|
@hfutatzhanghb You can add a UT, like #6994, TestRouterAsyncSnapshot. |
KeeProMise
reviewed
Oct 8, 2024
| import static org.apache.hadoop.hdfs.server.federation.router.async.AsyncUtil.asyncApply; | ||
| import static org.apache.hadoop.hdfs.server.federation.router.async.AsyncUtil.asyncReturn; | ||
|
|
||
| public class AsyncErasureCoding extends ErasureCoding{ |
There was a problem hiding this comment.
"ErasureCoding{" -> "ErasureCoding {"
There was a problem hiding this comment.
Thanks, have fixed.
|
💔 -1 overall
This message was automatically generated. |
|
💔 -1 overall
This message was automatically generated. |
|
@Hexiaoqiao @KeeProMise Sir, have added UT. PTAL when you have free time, thanks~ |
|
💔 -1 overall
This message was automatically generated. |
|
💔 -1 overall
This message was automatically generated. |
|
💔 -1 overall
This message was automatically generated. |
|
🎊 +1 overall
This message was automatically generated. |
|
@hfutatzhanghb LGTM, @Hexiaoqiao if you have time, please take a look at the PR. |
KeeProMise
approved these changes
Oct 10, 2024
Hexiaoqiao
reviewed
Oct 15, 2024
There was a problem hiding this comment.
Thanks @KeeProMise and @hfutatzhanghb for your works. Leave nit comments inline. Another un-related thing, is it better to organize async feature to one single package under router? Thanks again.
| return asyncReturn(ErasureCodingPolicy.class); | ||
| } | ||
|
|
||
|
|
There was a problem hiding this comment.
Thanks sir. fixed.
| import static org.apache.hadoop.hdfs.server.federation.router.async.AsyncUtil.asyncApply; | ||
| import static org.apache.hadoop.hdfs.server.federation.router.async.AsyncUtil.asyncReturn; | ||
|
|
||
| public class AsyncErasureCoding extends ErasureCoding { |
There was a problem hiding this comment.
Some other interface such as removeErasureCodingPolicy do not need to override with async?
There was a problem hiding this comment.
Yes, such interface do not need to refactor. They can work well in both sync and async mode.
There was a problem hiding this comment.
Hi, @Hexiaoqiao because we used option 2, removeErasureCodingPolicy does not need to thenApply the request result, so the caller can directly obtain the CompletableFuture object from the thread variable.here's an explanation:
4 tasks
|
🎊 +1 overall
This message was automatically generated. |
Hexiaoqiao
approved these changes
Oct 16, 2024
|
@hfutatzhanghb Thanks for your contribution! |
KeeProMise
pushed a commit
to KeeProMise/hadoop
that referenced
this pull request
Nov 21, 2024
…). Contributed by hfutatzhanghb. Reviewed-by: Jian Zhang <keepromise@apache.org> Signed-off-by: He Xiaoqiao <hexiaoqiao@apache.org>
KeeProMise
pushed a commit
to KeeProMise/hadoop
that referenced
this pull request
Nov 21, 2024
…). Contributed by hfutatzhanghb. Reviewed-by: Jian Zhang <keepromise@apache.org> Signed-off-by: He Xiaoqiao <hexiaoqiao@apache.org>
KeeProMise
pushed a commit
to KeeProMise/hadoop
that referenced
this pull request
Jan 17, 2025
…). Contributed by hfutatzhanghb. Reviewed-by: Jian Zhang <keepromise@apache.org> Signed-off-by: He Xiaoqiao <hexiaoqiao@apache.org>
KeeProMise
pushed a commit
to KeeProMise/hadoop
that referenced
this pull request
Jan 20, 2025
…). Contributed by hfutatzhanghb. Reviewed-by: Jian Zhang <keepromise@apache.org> Signed-off-by: He Xiaoqiao <hexiaoqiao@apache.org>
4 tasks
KeeProMise
pushed a commit
to KeeProMise/hadoop
that referenced
this pull request
Feb 11, 2025
…). Contributed by hfutatzhanghb. Reviewed-by: Jian Zhang <keepromise@apache.org> Signed-off-by: He Xiaoqiao <hexiaoqiao@apache.org>
KeeProMise
pushed a commit
that referenced
this pull request
Feb 14, 2025
…ontributed by hfutatzhanghb. Reviewed-by: Jian Zhang <keepromise@apache.org> Signed-off-by: He Xiaoqiao <hexiaoqiao@apache.org>
KeeProMise
pushed a commit
to KeeProMise/hadoop
that referenced
this pull request
Feb 20, 2025
…). Contributed by hfutatzhanghb. Reviewed-by: Jian Zhang <keepromise@apache.org> Signed-off-by: He Xiaoqiao <hexiaoqiao@apache.org>
KeeProMise
pushed a commit
to KeeProMise/hadoop
that referenced
this pull request
Feb 20, 2025
…). Contributed by hfutatzhanghb. Reviewed-by: Jian Zhang <keepromise@apache.org> Signed-off-by: He Xiaoqiao <hexiaoqiao@apache.org>
Hexiaoqiao
pushed a commit
to Hexiaoqiao/hadoop
that referenced
this pull request
Feb 20, 2025
…). Contributed by hfutatzhanghb. Reviewed-by: Jian Zhang <keepromise@apache.org> Signed-off-by: He Xiaoqiao <hexiaoqiao@apache.org>
adideshpande
pushed a commit
to adideshpande/hadoop
that referenced
this pull request
Feb 27, 2025
…). Contributed by hfutatzhanghb. Reviewed-by: Jian Zhang <keepromise@apache.org> Signed-off-by: He Xiaoqiao <hexiaoqiao@apache.org>
YanivKunda
pushed a commit
to YanivKunda/hadoop
that referenced
this pull request
Mar 23, 2025
…). Contributed by hfutatzhanghb. Reviewed-by: Jian Zhang <keepromise@apache.org> Signed-off-by: He Xiaoqiao <hexiaoqiao@apache.org>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of PR
The main new addition is AsyncErasureCoding, which extends ErasureCoding so that supports asynchronous rpc.