HDFS-17640.[ARR] RouterClientProtocol supports asynchronous rpc. #7188
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
💔 -1 overall
This message was automatically generated. |
a285ede to
8511acd
Compare
|
💔 -1 overall
This message was automatically generated. |
8511acd to
8944771
Compare
|
💔 -1 overall
This message was automatically generated. |
|
💔 -1 overall
This message was automatically generated. |
|
💔 -1 overall
This message was automatically generated. |
|
💔 -1 overall
This message was automatically generated. |
|
💔 -1 overall
This message was automatically generated. |
|
🎊 +1 overall
This message was automatically generated. |
|
@Hexiaoqiao Hi, if you have time, please help to take a look at this PR, thanks! |
|
💔 -1 overall
This message was automatically generated. |
|
🎊 +1 overall
This message was automatically generated. |
KeeProMise
approved these changes
Dec 31, 2024
Hexiaoqiao
reviewed
Dec 31, 2024
| RemoteMethod method = new RemoteMethod("rename", | ||
| new Class<?>[] {String.class, String.class}, | ||
| new RemoteParam(), dstParam); | ||
| isMultiDestDirectory(src); |
There was a problem hiding this comment.
Addendum: What this method invoke want to do? Thanks.
There was a problem hiding this comment.
HI, @Hexiaoqiao, this is the asynchronous implementation corresponding to the rename method of RouterClientProtocol below. It calls isMultiDestDirectory and obtains the return value of isMultiDestDirectory through asyncApply(...) for subsequent processing.
// RouterClientProtocol#rename
RemoteMethod method = new RemoteMethod("rename",
new Class<?>[] {String.class, String.class},
new RemoteParam(), dstParam);
if (isMultiDestDirectory(src)) {
if (locs.size() != srcLocations.size()) {
throw new IOException("Rename of " + src + " to " + dst + " is not"
+ " allowed. The number of remote locations for both source and"
+ " target should be same.");
}
return rpcClient.invokeAll(locs, method);
} else {
return rpcClient.invokeSequential(locs, method, Boolean.class,
Boolean.TRUE);
}There was a problem hiding this comment.
Got it, thanks. Others look good to me.
|
@hfutatzhanghb thanks for your contribution, and @Hexiaoqiao thanks for your review, merged. |
4 tasks
KeeProMise
added a commit
to KeeProMise/hadoop
that referenced
this pull request
Jan 17, 2025
…che#7188) Co-authored-by: Jian Zhang <keepromise@apache.org>
KeeProMise
added a commit
to KeeProMise/hadoop
that referenced
this pull request
Jan 20, 2025
…che#7188) Co-authored-by: Jian Zhang <keepromise@apache.org>
4 tasks
KeeProMise
added a commit
to KeeProMise/hadoop
that referenced
this pull request
Jan 22, 2025
…che#7188) Co-authored-by: Jian Zhang <keepromise@apache.org>
KeeProMise
added a commit
to KeeProMise/hadoop
that referenced
this pull request
Jan 22, 2025
…che#7188) Co-authored-by: Jian Zhang <keepromise@apache.org>
KeeProMise
added a commit
to KeeProMise/hadoop
that referenced
this pull request
Feb 11, 2025
…che#7188) Co-authored-by: Jian Zhang <keepromise@apache.org>
KeeProMise
added a commit
that referenced
this pull request
Feb 14, 2025
Co-authored-by: Jian Zhang <keepromise@apache.org>
KeeProMise
added a commit
to KeeProMise/hadoop
that referenced
this pull request
Feb 20, 2025
…che#7188) Co-authored-by: Jian Zhang <keepromise@apache.org>
KeeProMise
added a commit
to KeeProMise/hadoop
that referenced
this pull request
Feb 20, 2025
…che#7188) Co-authored-by: Jian Zhang <keepromise@apache.org>
Hexiaoqiao
pushed a commit
to Hexiaoqiao/hadoop
that referenced
this pull request
Feb 20, 2025
…che#7188) Co-authored-by: Jian Zhang <keepromise@apache.org>
adideshpande
pushed a commit
to adideshpande/hadoop
that referenced
this pull request
Feb 27, 2025
…che#7188) Co-authored-by: Jian Zhang <keepromise@apache.org>
YanivKunda
pushed a commit
to YanivKunda/hadoop
that referenced
this pull request
Mar 23, 2025
…che#7188) Co-authored-by: Jian Zhang <keepromise@apache.org>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of PR
RouterClientProtocol should support asynchronous rpc.