-
Notifications
You must be signed in to change notification settings - Fork 9k
YARN-11761. [JDK17] Upgrade JUnit from 4 to 5 in hadoop-yarn-services-core. #7374
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
💔 -1 overall
This message was automatically generated. |
💔 -1 overall
This message was automatically generated. |
💔 -1 overall
This message was automatically generated. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
+1, pending successful pre-submit run on the latest version of the patch. Thank you, @slfan1989 .
🎊 +1 overall
This message was automatically generated. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, there are two minor checkstyle warnings that need to fixed.
feel free to commit once you fix them
🎊 +1 overall
This message was automatically generated. |
…-core. (apache#7374) Co-authored-by: Ayush Saxena <ayushsaxena@apache.org> Co-authored-by: Chris Nauroth <cnauroth@apache.org> Reviewed-by: Ayush Saxena <ayushsaxena@apache.org> Reviewed-by: Chris Nauroth <cnauroth@apache.org> Signed-off-by: Shilun Fan <slfan1989@apache.org>
…-core. (apache#7374) Co-authored-by: Ayush Saxena <ayushsaxena@apache.org> Co-authored-by: Chris Nauroth <cnauroth@apache.org> Reviewed-by: Ayush Saxena <ayushsaxena@apache.org> Reviewed-by: Chris Nauroth <cnauroth@apache.org> Signed-off-by: Shilun Fan <slfan1989@apache.org>
Description of PR
JIRA: YARN-11761. [JDK17] Upgrade JUnit from 4 to 5 in hadoop-yarn-services-core.
How was this patch tested?
For code changes:
LICENSE
,LICENSE-binary
,NOTICE-binary
files?