-
Notifications
You must be signed in to change notification settings - Fork 9k
HADOOP-19415. [JDK17] Upgrade JUnit from 4 to 5 in hadoop-common Part6. #7375
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
💔 -1 overall
This message was automatically generated. |
💔 -1 overall
This message was automatically generated. |
This PR involves a lot of dependencies, and I still need some time to sort everything out. I expect it will take another 1-2 days to complete. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oh wow, 240 files changes. :-D Any chance of splitting it into smaller PRs? If not, I understand.
💔 -1 overall
This message was automatically generated. |
💔 -1 overall
This message was automatically generated. |
@cnauroth Thank you for reviewing this PR! This PR involves modifications to the dependencies of hadoop-common and other modules, and at this point, these changes need to be made together, so splitting them is not feasible. We realize that this PR is quite large, and it may require more time for further optimization and refinement. During the code review process, we would appreciate your help. I will also ensure that everything is properly prepared before submitting the PR for review. |
💔 -1 overall
This message was automatically generated. |
6712621
to
45cbe89
Compare
💔 -1 overall
This message was automatically generated. |
💔 -1 overall
This message was automatically generated. |
💔 -1 overall
This message was automatically generated. |
@cnauroth @steveloughran The overall progress of this PR has reached 80%, and I plan to deliver it this week. However, I have a question: will increasing the memory configuration of the maven-surefire-plugin help alleviate the memory overflow issue in the HDFS module? |
I took a look at the test failure, and it does look like this might help. I wonder why the JUnit upgrade would trigger this though. It's BTW, I will be traveling next week and probably unavailable for code reviews. |
💔 -1 overall
This message was automatically generated. |
@cnauroth Thank you very much for your help with code reviews recently! Wishing you a pleasant trip! |
fd33882
to
7501b2a
Compare
💔 -1 overall
This message was automatically generated. |
💔 -1 overall
This message was automatically generated. |
@steveloughran @anujmodi2021 @Hexiaoqiao @ayushtkn In parts 1 to 5 of HADOOP-19415, we have upgraded the majority of unit tests in the Hadoop-Common module to JUnit5. Starting from part 6, we will focus on upgrading the dependency-related code. The key class in part 6 is I have done my best to verify and test the changes, but I need everyone’s help with the validation. |
💔 -1 overall
This message was automatically generated. |
c27908f
to
5067082
Compare
Description of PR
JIRA: HADOOP-19415. [JDK17] Upgrade JUnit from 4 to 5 in hadoop-common Part6.
How was this patch tested?
For code changes:
LICENSE
,LICENSE-binary
,NOTICE-binary
files?