HDFS-17749. [ARR] Fix wrong results due to the wrong usage of asyncComplete in getListing. #7466
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
💔 -1 overall
This message was automatically generated. |
|
💔 -1 overall
This message was automatically generated. |
91c09e5 to
43833f5
Compare
|
🎊 +1 overall
This message was automatically generated. |
|
@Hexiaoqiao @KeeProMise Sir, PTAL at this pr when you have free time , thanks a lot. |
KeeProMise
reviewed
Mar 19, 2025
| @@ -355,7 +355,6 @@ public boolean mkdirs(String src, FsPermission masked, boolean createParent) | |||
| return rpcClient.invokeAll(locations, method); | |||
| } | |||
|
|
|||
| asyncComplete(false); | |||
There was a problem hiding this comment.
Hi, @hfutatzhanghb I just took a look at this method, and I think it should work fine without the modifications you suggested. First, set the completeFuture in the thread pool variable to false. Next, if locations.size() > 1, the completeFuture after execution will replace the thread variable. If locations.size() <= 1, then since the initial value of completeFuture is set to false, the subsequent asynchronous call code will be executed.
There was a problem hiding this comment.
Hi, @KeeProMise , thanks for your reviewing. Have reverted mkdirs and other rpcs not affected by asyncComplete method to reduce code duplication. Thanks again.
asyncComplete(null); // Handler thread
asyncApply(() -> {
getFileInfo(); // issue a rpc request.
asyncApply(); // AsyncRepsonder thread.
}); // The handler thread variable will be set to the CompletableFuture object after the execution of asyncApply.look AsyncUtil#asyncApply(...) public static <T, R> void asyncApply(ApplyFunction<T, R> function) {
CompletableFuture<T> completableFuture =
(CompletableFuture<T>) CUR_COMPLETABLE_FUTURE.get();
assert completableFuture != null;
CompletableFuture<R> result = function.apply(completableFuture);
CUR_COMPLETABLE_FUTURE.set((CompletableFuture<Object>) result); // will reset CUR_COMPLETABLE_FUTURE use the CompletableFuture object after the execution
} |
KeeProMise
reviewed
Mar 21, 2025
Comment on lines
-502
to
+516
| return null; | ||
| return finalNamenodeListingExists; | ||
| }); | ||
| } else { | ||
| asyncComplete(namenodeListingExists); | ||
| } | ||
| asyncComplete(namenodeListingExists); | ||
|
|
43833f5 to
a28d1c1
Compare
f2550b2 to
f6dc774
Compare
|
🎊 +1 overall
This message was automatically generated. |
|
💔 -1 overall
This message was automatically generated. |
|
💔 -1 overall
This message was automatically generated. |
|
💔 -1 overall
This message was automatically generated. |
|
🎊 +1 overall
This message was automatically generated. |
695c975 to
e2581db
Compare
KeeProMise
reviewed
Mar 24, 2025
Comment on lines
+56
to
+60
| // Get the end points. | ||
| nnContext0 = cluster.getNamenode("ns0", null); | ||
| nnContext1 = cluster.getNamenode("ns1", null); | ||
| nnFs0 = nnContext0.getFileSystem(); | ||
| nnFs1 = nnContext1.getFileSystem(); |
There was a problem hiding this comment.
hi @hfutatzhanghb Have these variables been used?
|
yes, they were used in super class
---- Replied Message ----
| From | ***@***.***> |
| Date | 03/24/2025 22:41 |
| To | ***@***.***> |
| Cc | ***@***.***>***@***.***> |
| Subject | Re: [apache/hadoop] HDFS-17749. [ARR] Fix wrong results due to the wrong usage of asyncComplete in getListing. (PR #7466) |
@KeeProMise commented on this pull request.
In hadoop-hdfs-project/hadoop-hdfs-rbf/src/test/java/org/apache/hadoop/hdfs/server/federation/router/async/TestRouterAsyncMountTable.java:
+ // Get the end points.
+ nnContext0 = cluster.getNamenode("ns0", null);
+ nnContext1 = cluster.getNamenode("ns1", null);
+ nnFs0 = nnContext0.getFileSystem();
+ nnFs1 = nnContext1.getFileSystem();
hi @hfutatzhanghb Have these variables been used?
—
Reply to this email directly, view it on GitHub, or unsubscribe.
You are receiving this because you were mentioned.Message ID: ***@***.***>
|
|
🎊 +1 overall
This message was automatically generated. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of PR
May get wrong results due to the wrong usage of asyncComplete in getListing RPC.
The root cause is as below:
How was this patch tested?
Add unit tests TestRouterAsyncMountTable.java.
How to reproduce?
Use original codes to run TestRouterAsyncMountTable.java
Some of unit tests will not pass due to the inaccurate results.