8000 HDFS-17750. [ARR] RouterWebHdfsMethods adapts to async rpc. by hfutatzhanghb · Pull Request #7462 · apache/hadoop · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

HDFS-17750. [ARR] RouterWebHdfsMethods adapts to async rpc. #7462

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 11, 2025
Merged

HDFS-17750. [ARR] RouterWebHdfsMethods adapts to async rpc. #7462

merged 1 commit into from
Mar 11, 2025

Conversation

hfutatzhanghb
Copy link
Contributor

Description of PR

RouterWebHdfsMethods adapts to async rpc since it uses getCreateLocation which should be chanaged to getCreateLocationAsync in async rpc mode.

How was this patch tested?

Add an unit test.

@hfutatzhanghb
Copy link
Contributor Author

@Hexiaoqiao @KeeProMise Sir, cc this pr when you have free time, Thanks a lot.

@slfan1989
Copy link
Contributor

@KeeProMise @hfutatzhanghb I have a question regarding the future improvement plan for ARR. Is it possible to coordinate the schedule? We will soon begin upgrading the HDFS module to Junit5, and I'm concerned there might be conflicts. If there are significant changes to ARR, would it be possible to create a separate branch to handle them?

cc: @Hexiaoqiao

@hadoop-yetus
Copy link

🎊 +1 overall

Vote Subsystem Runtime Logfile Comment
+0 🆗 reexec 12m 10s Docker mode activated.
_ Prechecks _
+1 💚 dupname 0m 0s No case conflicting files found.
+0 🆗 codespell 0m 0s codespell was not available.
+0 🆗 detsecrets 0m 0s detect-secrets was not available.
+1 💚 @author 0m 0s The patch does not contain any @author tags.
+1 💚 test4tests 0m 0s The patch appears to include 2 new or modified test files.
_ trunk Compile Tests _
+1 💚 mvninstall 35m 18s trunk passed
+1 💚 compile 1m 6s trunk passed with JDK Ubuntu-11.0.26+4-post-Ubuntu-1ubuntu120.04
+1 💚 compile 0m 44s trunk passed with JDK Private Build-1.8.0_442-8u442-b06us1-0ubuntu120.04-b06
+1 💚 checkstyle 0m 33s trunk passed
+1 💚 mvnsite 0m 47s trunk passed
+1 💚 javadoc 0m 43s trunk passed with JDK Ubuntu-11.0.26+4-post-Ubuntu-1ubuntu120.04
+1 💚 javadoc 0m 34s trunk passed with JDK Private Build-1.8.0_442-8u442-b06us1-0ubuntu120.04-b06
+1 💚 spotbugs 1m 31s trunk passed
+1 💚 shadedclient 34m 17s branch has no errors when building and testing our client artifacts.
_ Patch Compile Tests _
+1 💚 mvninstall 0m 35s the patch passed
+1 💚 compile 0m 58s the patch passed with JDK Ubuntu-11.0.26+4-post-Ubuntu-1ubuntu120.04
+1 💚 javac 0m 58s the patch passed
+1 💚 compile 0m 34s the patch passed with JDK Private Build-1.8.0_442-8u442-b06us1-0ubuntu120.04-b06
+1 💚 javac 0m 34s the patch passed
+1 💚 blanks 0m 0s The patch has no blanks issues.
+1 💚 checkstyle 0m 20s the patch passed
+1 💚 mvnsite 0m 37s the patch passed
+1 💚 javadoc 0m 29s the patch passed with JDK Ubuntu-11.0.26+4-post-Ubuntu-1ubuntu120.04
+1 💚 javadoc 0m 25s the patch passed with JDK Private Build-1.8.0_442-8u442-b06us1-0ubuntu120.04-b06
+1 💚 spotbugs 1m 28s the patch passed
+1 💚 shadedclient 34m 30s patch has no errors when building and testing our client artifacts.
_ Other Tests _
+1 💚 unit 42m 59s hadoop-hdfs-rbf in the patch passed.
+1 💚 asflicense 0m 39s The patch does not generate ASF License warnings.
172m 57s
Subsystem Report/Notes
Docker ClientAPI=1.48 ServerAPI=1.48 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-7462/1/artifact/out/Dockerfile
GITHUB PR #7462
Optional Tests dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient spotbugs checkstyle codespell detsecrets
uname Linux 96cc067ca0c3 5.15.0-131-generic #141-Ubuntu SMP Fri Jan 10 21:18:28 UTC 2025 x86_64 x86_64 x86_64 GNU/Linux
Build tool maven
Personality dev-support/bin/hadoop.sh
git revision trunk / d09531a
Default Java Private Build-1.8.0_442-8u442-b06us1-0ubuntu120.04-b06
Multi-JDK versions /usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-11.0.26+4-post-Ubuntu-1ubuntu120.04 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_442-8u442-b06us1-0ubuntu120.04-b06
Test Results https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-7462/1/testReport/
Max. process+thread count 3366 (vs. ulimit of 5500)
modules C: hadoop-hdfs-project/hadoop-hdfs-rbf U: hadoop-hdfs-project/hadoop-hdfs-rbf
Console output https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-7462/1/console
versions git=2.25.1 maven=3.6.3 spotbugs=4.2.2
Powered by Apache Yetus 0.14.0 https://yetus.apache.org

This message was automatically generated.

KeeProMise
KeeProMise approved these changes Mar 5, 2025
View reviewed changes
Copy link
Member
@KeeProMise KeeProMise left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@hfutatzhanghb hfutatzhanghb mentioned this pull request Mar 6, 2025
Open
@KeeProMise KeeProMise merged commit 1416c94 into apache:trunk Mar 11, 2025
4 checks passed
@KeeProMise
Copy link
Member

@hfutatzhanghb Thanks for your contribution! merged!

@hfutatzhanghb hfutatzhanghb deleted the HDFS-17750 branch Marc 8219 h 11, 2025 02:28
YanivKunda pushed a commit to YanivKunda/hadoop that referenced this pull request Mar 23, 2025
@hfutatzhanghb @YanivKunda
HDFS-17750. [ARR] RouterWebHdfsMethods adapts to async rpc. (apache#7462
4f55f47 
). Contributed by hfutatzhanghb.

Reviewed-by: Jian Zhang <keepromise@apache.org>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@KeeProMise KeeProMise KeeProMise approved these changes

Assignees
No one assigned
Labels
HDFS RBF trunk
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@hfutatzhanghb @slfan1989 @hadoop-yetus @KeeProMise
0