HADOOP-19426. [JDK17] Upgrade JUnit from 4 to 5 in hadoop-azure-datalake Part2. #7757
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
💔 -1 overall
This message was automatically generated. |
|
🎊 +1 overall
This message was automatically generated. |
|
@anujmodi2021 Could you please help review this PR? Thank you very much! |
There was a problem hiding this comment.
Pull Request Overview
This PR migrates the TestAdlPermissionLive class from JUnit 4 to JUnit 5 parameterized tests and removes the custom Parallelized runner.
- Converted JUnit 4 annotations and assertions to their JUnit 5 equivalents.
- Removed the
Parallelizedhelper and switched to@ParameterizedTestwith@MethodSource. - Updated imports and test setup/cleanup methods to use JUnit 5 APIs.
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| hadoop-tools/hadoop-azure-datalake/src/test/java/org/apache/hadoop/fs/adl/live/TestAdlPermissionLive.java | Migrated tests to JUnit 5 parameterized style, replaced annotations and assertions |
| hadoop-tools/hadoop-azure-datalake/src/test/java/org/apache/hadoop/fs/adl/common/Parallelized.java | Removed obsolete JUnit 4 parallel runner helper |
Comments suppressed due to low confidence (2)
hadoop-tools/hadoop-azure-datalake/src/test/java/org/apache/hadoop/fs/adl/live/TestAdlPermissionLive.java:54
- [nitpick] The method name
initTestAdlPermissionLiveis verbose; consider renaming to a more concise name likesetupPermissionTestto better reflect its role.
public void initTestAdlPermissionLive(FsPermission pTestPermission) throws Exception {
hadoop-tools/hadoop-azure-datalake/src/test/java/org/apache/hadoop/fs/adl/live/TestAdlPermissionLive.java:84
- Consider annotating this setup method with
@BeforeEach(JUnit 5) instead of manual invocation in your init helper, to align with JUnit 5 conventions and reduce boilerplate.
public void setUp() throws Exception {
| } | ||
|
|
||
| @Parameterized.Parameters(name = "{0}") | ||
| public static Collection adlCreateNonRecursiveTestData() |
There was a problem hiding this comment.
Use a parameterized generic return type Collection<FsPermission> for the data provider to avoid raw-type warnings and improve type safety.
Suggested change
| public static Collection adlCreateNonRecursiveTestData() | |
| public static Collection<FsPermission[]> adlCreateNonRecursiveTestData() |
Copilot uses AI. Check for mistakes.
| public static void cleanUp() throws IOException, URISyntaxException { | ||
| if (AdlStorageConfiguration.isContractTestEnabled()) { | ||
| Assert.assertTrue(AdlStorageConfiguration.createStorageConnector() | ||
| assertTrue(AdlStorageConfiguration.createStorageConnector() | ||
| .delete(testRoot, true)); |
There was a problem hiding this comment.
[nitpick] Add a descriptive message to this assertion to clarify failure context, e.g., assertTrue(..., "Failed to clean up testRoot directory").
Suggested change
| .delete(testRoot, true)); | |
| .delete(testRoot, true), "Failed to clean up testRoot directory during cleanup."); |
Copilot uses AI. Check for mistakes.
anujmodi2021
approved these changes
Jul 2, 2025
There was a problem hiding this comment.
+1 LGTM
Just need to check if we need to add @beforeeach and @AfterEach at required places or not
| .delete(testRoot, true)); | ||
| } | ||
| } | ||
|
|
||
| @Before |
There was a problem hiding this comment.
Do we need @beforeeach here after removing @before?
There was a problem hiding this comment.
@anujmodi2021 Thank you for your question! ParameterizedTest in JUnit 5 is a special type of unit test. Unlike JUnit 4, ParameterizedTest requires the initialization of certain parameters directly in the test method, so the setup function is executed at that point. If we add @BeforeEach, the variables in setup would not be initialized yet. Therefore, we don't need to add @BeforeEach; instead, we should call setup within initTestAdlPermissionLive.
|
Thanks a lot @slfan1989 |
|
@anujmodi2021 @zhtttylz Thank you very much for the review! |
74 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of PR
JIRA: HADOOP-19426. [JDK17] Upgrade JUnit from 4 to 5 in hadoop-azure-datalake Part2.
How was this patch tested?
mvn clean test & junit test.
For code changes:
LICENSE,LICENSE-binary,NOTICE-binaryfiles?