8000 HADOOP-19608. Upgrade to Junit 5.13.3 by steveloughran · Pull Request #7785 · apache/hadoop · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

HADOOP-19608. Upgrade to Junit 5.13.3 #7785

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: trunk
Choose a base branch
from
Open

HADOOP-19608. Upgrade to Junit 5.13.3 #7785

wants to merge 1 commit into from
+4 −9

Conversation

steveloughran
Copy link
Contributor

HADOOP-19608

  • junit.jupiter and junit.vintage => 5.13.3
  • junit.platform => 1.13.3
  • Surefire => 3.5.3. Without that tests weren't being found.

How was this patch tested?

Worked on the iceberg bulk delete branch for its new parameterized test class.
Not yet tested anything else ... let's see what yetus says. I'll do the ITest run

For code changes:

  • Does the title or this PR starts with the corresponding JIRA issue id (e.g. 'HADOOP-17799. Your PR title ...')?
  • Object storage: have the integration tests been executed and the endpoint declared according to the connector-specific documentation?
  • If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under ASF 2.0?
  • If applicable, have you updated the LICENSE, LICENSE-binary, NOTICE-binary files?

@hadoop-yetus
Copy link

💔 -1 overall

Vote Subsystem Runtime Logfile Comment
+0 🆗 reexec 0m 30s Docker mode activated.
_ Prechecks _
+1 💚 dupname 0m 0s No case conflicting files found.
+0 🆗 codespell 0m 0s codespell was not available.
+0 🆗 detsecrets 0m 0s detect-secrets was not available.
+0 🆗 xmllint 0m 0s xmllint was not available.
+1 💚 @author 0m 0s The patch does not contain any @author tags.
-1 ❌ test4tests 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
_ trunk Compile Tests _
+1 💚 mvninstall 24m 28s trunk passed
+1 💚 compile 0m 16s trunk passed with JDK Ubuntu-11.0.27+6-post-Ubuntu-0ubuntu120.04
+1 💚 compile 0m 16s trunk passed with JDK Private Build-1.8.0_452-8u452-gaus1-0ubuntu120.04-b09
+1 💚 mvnsite 0m 17s trunk passed
+1 💚 javadoc 0m 21s trunk passed with JDK Ubuntu-11.0.27+6-post-Ubuntu-0ubuntu120.04
+1 💚 javadoc 0m 17s trunk passed with JDK Private Build-1.8.0_452-8u452-gaus1-0ubuntu120.04-b09
+1 💚 shadedclient 46m 31s branch has no errors when building and testing our client artifacts.
_ Patch Compile Tests _
+1 💚 mvninstall 0m 8s the patch passed
+1 💚 compile 0m 9s the patch passed with JDK Ubuntu-11.0.27+6-post-Ubuntu-0ubuntu120.04
+1 💚 javac 0m 9s the patch passed
+1 💚 compile 0m 10s the patch passed with JDK Private Build-1.8.0_452-8u452-gaus1-0ubuntu120.04-b09
+1 💚 javac 0m 10s the patch passed
+1 💚 blanks 0m 0s The patch has no blanks issues.
+1 💚 mvnsite 0m 13s the patch passed
+1 💚 javadoc 0m 11s the patch passed with JDK Ubuntu-11.0.27+6-post-Ubuntu-0ubuntu120.04
+1 💚 javadoc 0m 11s the patch passed with JDK Private Build-1.8.0_452-8u452-gaus1-0ubuntu120.04-b09
-1 ❌ shadedclient 1m 54s patch has errors when building and testing our client artifacts.
_ Other Tests _
+1 💚 unit 0m 10s hadoop-project in the patch passed.
+1 💚 asflicense 0m 21s The patch does not generate ASF License warnings.
51m 6s
Subsystem Report/Notes
Docker ClientAPI=1.51 ServerAPI=1.51 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-7785/1/artifact/out/Dockerfile
GITHUB PR #7785
Optional Tests dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient codespell detsecrets xmllint
uname Linux 82ce33eaf23e 5.15.0-143-generic #153-Ubuntu SMP Fri Jun 13 19:10:45 UTC 2025 x86_64 x86_64 x86_64 GNU/Linux
Build tool maven
Personality dev-support/bin/hadoop.sh
git revision trunk / c8c82fd
Default Java Private Build-1.8.0_452-8u452-gaus1-0ubuntu120.04-b09
Multi-JDK versions /usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-11.0.27+6-post-Ubuntu-0ubuntu120.04 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_452-8u452-gaus1-0ubuntu120.04-b09
Test Results https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-7785/1/testReport/
Max. process+thread count 561 (vs. ulimit of 5500)
modules C: hadoop-project U: hadoop-project
Console output https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-7785/1/console
versions git=2.25.1 maven=3.6.3
Powered by Apache Yetus 0.14.0 https://yetus.apache.org

This message was automatically generated.

@hadoop-yetus
Copy link

💔 -1 overall

Vote Subsystem Runtime Logfile Comment
+0 🆗 reexec 0m 21s Docker mode activated.
_ Prechecks _
+1 💚 dupname 0m 0s No case conflicting files found.
+0 🆗 codespell 0m 1s codespell was not available.
+0 🆗 detsecrets 0m 1s detect-secrets was not available.
+0 🆗 xmllint 0m 1s xmllint was not available.
+1 💚 @author 0m 0s The patch does not contain any @author tags.
-1 ❌ test4tests 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
_ trunk Compile Tests _
+1 💚 mvninstall 24m 26s trunk passed
+1 💚 compile 0m 16s trunk passed with JDK Ubuntu-11.0.27+6-post-Ubuntu-0ubuntu120.04
+1 💚 compile 0m 16s trunk passed with JDK Private Build-1.8.0_452-8u452-gaus1-0ubuntu120.04-b09
+1 💚 mvnsite 0m 18s trunk passed
+1 💚 javadoc 0m 21s trunk passed with JDK Ubuntu-11.0.27+6-post-Ubuntu-0ubuntu120.04
+1 💚 javadoc 0m 16s trunk passed with JDK Private Build-1.8.0_452-8u452-gaus1-0ubuntu120.04-b09
+1 💚 shadedclient 46m 26s branch has no errors when building and testing our client artifacts.
_ Patch Compile Tests _
+1 💚 mvninstall 0m 11s the patch passed
+1 💚 compile 0m 10s the patch passed with JDK Ubuntu-11.0.27+6-post-Ubuntu-0ubuntu120.04
+1 💚 javac 0m 10s the patch passed
+1 💚 compile 0m 10s the patch passed with JDK Private Build-1.8.0_452-8u452-gaus1-0ubuntu120.04-b09
+1 💚 javac 0m 10s the patch passed
+1 💚 blanks 0m 0s The patch has no blanks issues.
+1 💚 mvnsite 0m 13s the patch passed
+1 💚 javadoc 0m 11s the patch passed with JDK Ubuntu-11.0.27+6-post-Ubuntu-0ubuntu120.04
+1 💚 javadoc 0m 10s the patch passed with JDK Private Build-1.8.0_452-8u452-gaus1-0ubuntu120.04-b09
-1 ❌ shadedclient 1m 52s patch has errors when building and testing our client artifacts.
_ Other Tests _
+1 💚 unit 0m 10s hadoop-project in the patch passed.
+1 💚 asflicense 0m 22s The patch does not generate ASF License warnings.
50m 54s
Subsystem Report/Notes
Docker ClientAPI=1.51 ServerAPI=1.51 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-7785/2/artifact/out/Dockerfile
GITHUB PR #7785
Optional Tests dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient codespell detsecrets xmllint
uname Linux 8b2e81dcd2bc 5.15.0-143-generic #153-Ubuntu SMP Fri Jun 13 19:10:45 UTC 2025 x86_64 x86_64 x86_64 GNU/Linux
Build tool maven
Personality dev-support/bin/hadoop.sh
git revision trunk / a33729c
Default Java Private Build-1.8.0_452-8u452-gaus1-0ubuntu120.04-b09
Multi-JDK versions /usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-11.0.27+6-post-Ubuntu-0ubuntu120.04 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_452-8u452-gaus1-0ubuntu120.04-b09
Test Results https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-7785/2/testReport/
Max. process+thread count 544 (vs. ulimit of 5500)
modules C: hadoop-project U: hadoop-project
Console output https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-7785/2/console
versions git=2.25.1 maven=3.6.3
Powered by Apache Yetus 0.14.0 https://yetus.apache.org

This message was automatically generated.

@steveloughran
Copy link
Contributor Author

aws failures (probably unrelated, given I'd not tested trunk yet)

[ERROR]   TestStagingPartitionedJobCommit.testReplaceWithDeleteFailure:259->verifyReplaceCommitActions:233 
Argument(s) are different! Wanted:
s3AFileSystem.delete(
    s3a://bucket-name/output/path/dateint=20161115/hour=14,
    true
);
-> at org.apache.hadoop.fs.s3a.S3AFileSystem.delete(S3AFileSystem.java:3538)
Actual invocations have different arguments:
s3AFileSystem.delete(
    s3a://bucket-name/output/path/dateint=20161116/hour=13,
    true
);
-> at org.apache.hadoop.fs.s3a.MockS3AFileSystem.delete(MockS3AFileSystem.java:272)
s3AFileSystem.delete(
    s3a://bucket-name/output/path/dateint=20161116/hour=14,
    true
);
-> at org.apache.hadoop.fs.s3a.MockS3AFileSystem.delete(MockS3AFileSystem.java:272)
s3AFileSystem.delete(
    s3a://bucket-name/output/path/dateint=20161115/hour=13,
    true
);
-> at org.apache.hadoop.fs.s3a.MockS3AFileSystem.delete(MockS3AFileSystem.java:272)
s3AFileSystem.delete(
    s3a://bucket-name/output/path/_temporary,
    true
);
-> at org.apache.hadoop.fs.s3a.MockS3AFileSystem.delete(MockS3AFileSystem.java:272)

@steveloughran
Copy link
Contributor Author
steveloughran commented Jul 7, 2025 •
edited
Loading

Surefire rejects me running without a named test

 mvit -Dparallel-tests -DtestsThreadCount=8 -Dtest=none

[ERROR] Failed to execute goal org.apache.maven.plugins:maven-surefire-plugin:3.5.3:test (default-test) on project hadoop-aws: No tests matching pattern "none" were executed! (Set -Dsurefire.failIfNoSpecifiedTests=false to ignore this error.) -> [Help 1]
[ERROR]

@steveloughran
HADOOP-19608. Upgrade to Junit 5.13.3
ac5300c 
* junit.jupiter and junit.vintage => 5.13.3
* junit.platform => 1.13.3
* Surefire => 3.5.3. Without that tests weren't being found.
* cut a duplicate and conflicting import of mockito-jupiter;
  maven was warning of this.
@steveloughran steveloughran force-pushed the build/HADOOP-19608-junit513 branch from a33729c to ac5300c Compare July 15, 2025 12:16
@ayushtkn
Copy link
Member

Surefire rejects me running without a named test

that is a known issue some surefire upgrade maybe did that. We can put that in pom & get rid of this problem

https://github.com/apache/hadoop/pull/5567/files#diff-9c5fb3d1b7e3b0f54bc5c4182965c4fe1f9023d449017cece3005d3f90e8e4d8R126-R128

Looking at the previous build results, I think the Jenkins didn't run any test, we might need to touch something here & there to trigger all the tests

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
build trunk
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@steveloughran @hadoop-yetus @ayushtkn
0