-
Notifications
You must be signed in to change notification settings - Fork 1.2k
Adding YARNContainerFactory. This allows OpenWhisk to run actions on Apache Hadoop clusters. #4129
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
7 commits
Select commit
Hold shift + click to select a range
35dfff9
Adding YARNContainerFactory. This allows OpenWhisk to run actions on …
SamHjelmfelt 62706d6
Added support for invoker HA. Each creates its own YARN service
SamHjelmfelt a7f7eed
Refactored to improve parallelism. Adding support for YARN container …
SamHjelmfelt d22175c
Accomodating changes to ContainerArgsConfig class
SamHjelmfelt 621bd3e
Adding license headers
SamHjelmfelt 4b94b3e
Formating changes
SamHjelmfelt 69532fb
Added comments to application.conf
SamHjelmfelt File filter
Filter by extension
Conversations
Failed to load comments. Retry
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
107 changes: 107 additions & 0 deletions
107
common/scala/src/main/scala/org/apache/openwhisk/core/yarn/YARNComponentActor.scala
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,107 @@ | ||
/* | ||
* Licensed to the Apache Software Foundation (ASF) under one or more | ||
* contributor license agreements. See the NOTICE file distributed with | ||
* this work for additional information regarding copyright ownership. | ||
* The ASF licenses this file to You under the Apache License, Version 2.0 | ||
* (the "License"); you may not use this file except in compliance with | ||
* the License. You may obtain a copy of the License at | ||
* | ||
* http://www.apache.org/licenses/LICENSE-2.0 | ||
* | ||
* Unless required by applicable law or agreed to in writing, software | ||
* distributed under the License is distributed on an "AS IS" BASIS, | ||
* WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
* See the License for the specific language governing permissions and | ||
* limitations under the License. | ||
*/ | ||
|
||
package org.apache.openwhisk.core.yarn | ||
|
||
import akka.actor.{Actor, ActorSystem} | ||
import akka.http.scaladsl.model.{HttpMethods, StatusCodes} | ||
import akka.stream.ActorMaterializer | ||
import org.apache.openwhisk.common.Logging | ||
import org.apache.openwhisk.core.entity.ExecManifest.ImageName | ||
import org.apache.openwhisk.core.yarn.YARNComponentActor.{CreateContainerAsync, RemoveContainer} | ||
import spray.json.{JsArray, JsNumber, JsObject, JsString} | ||
|
||
import scala.concurrent.ExecutionContext | ||
|
||
/** Submits create and decommission commands to YARN */ | ||
object YARNComponentActor { | ||
case object CreateContainerAsync | ||
case class RemoveContainer(component_instance_name: String) | ||
} | ||
|
||
class YARNComponentActor(actorSystem: ActorSystem, | ||
SamHjelmfelt marked this conversation as resolved.
Show resolved
Hide resolved
|
||
logging: Logging, | ||
yarnConfig: YARNConfig, | ||
serviceName: String, | ||
imageName: ImageName) | ||
extends Actor { | ||
|
||
implicit val as: ActorSystem = actorSystem | ||
implicit val materializer: ActorMaterializer = ActorMaterializer() | ||
implicit val ec: ExecutionContext = actorSystem.dispatcher | ||
|
||
//Adding a container via the YARN REST API is actually done by flexing the component's container pool to a certain size. | ||
// This actor must track the current containerCount in order to make the correct scale-up request. | ||
var containerCount: Int = 0 | ||
SamHjelmfelt marked this conversation as resolved.
Show resolved
Hide resolved
|
||
|
||
def receive: PartialFunction[Any, Unit] = { | ||
case CreateContainerAsync => | ||
sender ! createContainerAsync | ||
|
||
case RemoveContainer(component_instance_name) => | ||
sender ! removeContainer(component_instance_name) | ||
|
||
case input => | ||
throw new IllegalArgumentException("Unknown input: " + input) | ||
sender ! false | ||
} | ||
|
||
def createContainerAsync(): Unit = { | ||
logging.info(this, s"Using YARN to create a container with image ${imageName.name}...") | ||
|
||
val body = JsObject("number_of_containers" -> JsNumber(containerCount + 1)).compactPrint | ||
val response = YARNRESTUtil.submitRequestWithAuth( | ||
yarnConfig.authType, | ||
HttpMethods.PUT, | ||
s"${yarnConfig.masterUrl}/app/v1/services/$serviceName/components/${imageName.name}", | ||
body) | ||
response match { | ||
case httpresponse(StatusCodes.OK, content) => | ||
logging.info(this, s"Added container: ${imageName.name}. Response: $content") | ||
containerCount += 1 | ||
|
||
case httpresponse(_, _) => YARNRESTUtil.handleYARNRESTError(logging) | ||
} | ||
} | ||
|
||
def removeContainer(component_instance_name: String): Unit = { | ||
logging.info(this, s"Removing ${imageName.name} container: $component_instance_name ") | ||
if (containerCount <= 0) { | ||
logging.warn(this, "Already at 0 containers") | ||
} else { | ||
val body = JsObject( | ||
"components" -> JsArray( | ||
JsObject( | ||
"name" -> JsString(imageName.name), | ||
"decommissioned_instances" -> JsArray(JsString(component_instance_name))))).compactPrint | ||
val response = YARNRESTUtil.submitRequestWithAuth( | ||
yarnConfig.authType, | ||
HttpMethods.PUT, | ||
s"${yarnConfig.masterUrl}/app/v1/services/$serviceName", | ||
body) | ||
response match { | ||
case httpresponse(StatusCodes.OK, content) => | ||
logging.info( | ||
this, | ||
s"Successfully removed ${imageName.name} container: $component_instance_name. Response: $content") | ||
containerCount -= 1 | ||
|
||
case httpresponse(_, _) => YARNRESTUtil.handleYARNRESTError(logging) | ||
} | ||
} | ||
} | ||
} |
241 changes: 241 additions & 0 deletions
241
common/scala/src/main/scala/org/apache/openwhisk/core/yarn/YARNContainerFactory.scala
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,241 @@ | ||
/* | ||
* Licensed to the Apache Software Foundation (ASF) under one or more | ||
* contributor license agreements. See the NOTICE file distributed with | ||
* this work for additional information regarding copyright ownership. | ||
* The ASF licenses this file to You under the Apache License, Version 2.0 | ||
* (the "License"); you may not use this file except in compliance with | ||
* the License. You may obtain a copy of the License at | ||
* | ||
* http://www.apache.org/licenses/LICENSE-2.0 | ||
* | ||
* Unless required by applicable law or agreed to in writing, software | ||
* distributed under the License is distributed on an "AS IS" BASIS, | ||
* WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
* See the License for the specific language governing permissions and | ||
* limitations under the License. | ||
*/ | ||
|
||
package org.apache.openwhisk.core.yarn | ||
|
||
import akka.actor.{ActorRef, ActorSystem, Props} | ||
import akka.http.scaladsl.model.{HttpMethods, StatusCodes} | ||
import akka.pattern.ask | ||
import akka.util.Timeout | ||
import org.apache.openwhisk.common.{Logging, TransactionId} | ||
import org.apache.openwhisk.core.containerpool._ | ||
import org.apache.openwhisk.core.entity.ExecManifest.ImageName | ||
import org.apache.openwhisk.core.entity.{ByteSize, ExecManifest, InvokerInstanceId} | ||
import org.apache.openwhisk.core.yarn.YARNComponentActor.CreateContainerAsync | ||
import org.apache.openwhisk.core.{ConfigKeys, WhiskConfig} | ||
import pureconfig.loadConfigOrThrow | ||
import spray.json._ | ||
|
||
import scala.collection.immutable.HashMap | ||
import scala.concurrent.{blocking, ExecutionContext, Future} | ||
import scala.concurrent.duration._ | ||
import YARNJsonProtocol._ | ||
import akka.stream.ActorMaterializer | ||
|
||
case class YARNConfig(masterUrl: String, | ||
yarnLinkLogMessage: Boolean, | ||
serviceName: String, | ||
authType: String, | ||
kerberosPrincipal: String, | ||
kerberosKeytab: String, | ||
queue: String, | ||
memory: String, | ||
cpus: Int) | ||
|
||
object YARNContainerFactoryProvider extends ContainerFactoryProvider { | ||
override def instance(actorSystem: ActorSystem, | ||
logging: Logging, | ||
config: WhiskConfig, | ||
instance: InvokerInstanceId, | ||
parameters: Map[String, Set[String]]): ContainerFactory = | ||
new YARNContainerFactory(actorSystem, logging, config, instance, parameters) | ||
} | ||
|
||
class YARNContainerFactory(actorSystem: ActorSystem, | ||
SamHjelmfelt marked this conversation as resolved.
Show resolved
Hide resolved
|
||
logging: Logging, | ||
config: WhiskConfig, | ||
instance: InvokerInstanceId, | ||
parameters: Map[String, Set[String]], | ||
containerArgs: ContainerArgsConfig = | ||
loadConfigOrThrow[ContainerArgsConfig](ConfigKeys.containerArgs), | ||
yarnConfig: YARNConfig = loadConfigOrThrow[YARNConfig](ConfigKeys.yarn)) | ||
extends ContainerFactory { | ||
|
||
val images: Set[ImageName] = ExecManifest.runtimesManifest.runtimes.flatMap(a => a.versions.map(b => b.image)) | ||
|
||
//One actor of each type per image for parallelism | ||
private var yarnComponentActors: Map[ImageName, ActorRef] = HashMap[ImageName, ActorRef]() | ||
private var YARNContainerInfoActors: Map[ImageName, ActorRef] = HashMap[ImageName, ActorRef]() | ||
|
||
val serviceStartTimeoutMS = 60000 | ||
val retryWaitMS = 1000 | ||
val runCommand = "" | ||
val version = "1.0.0" | ||
val description = "OpenWhisk Action Service" | ||
|
||
//Allows for invoker HA | ||
val serviceName: String = yarnConfig.serviceName + "-" + instance.toInt | ||
|
||
val containerStartTimeoutMS = 60000 | ||
|
||
implicit val as: ActorSystem = actorSystem | ||
implicit val materializer: ActorMaterializer = ActorMaterializer() | ||
implicit val ec: ExecutionContext = actorSystem.dispatcher | ||
|
||
override def init(): Unit = { | ||
yarnComponentActors = images | ||
.map( | ||
SamHjelmfelt marked this conversation as resolved.
Show resolved
Hide resolved
|
||
i => | ||
( | ||
i, | ||
actorSystem.actorOf( | ||
Props(new YARNComponentActor(actorSystem, logging, yarnConfig, serviceName, i)), | ||
name = s"YARNComponentActor-${i.name}"))) | ||
.toMap | ||
YARNContainerInfoActors = images | ||
.map( | ||
i => | ||
( | ||
i, | ||
actorSystem.actorOf( | ||
Props(new YARNContainerInfoActor(actorSystem, logging, yarnConfig, serviceName, i)), | ||
name = s"YARNComponentInfoActor-${i.name}"))) | ||
.toMap | ||
blocking { | ||
implicit val timeout: Timeout = Timeout(serviceStartTimeoutMS.milliseconds) | ||
|
||
//Remove service if it already exists | ||
val serviceDef = | ||
YARNRESTUtil.downloadServiceDefinition(yarnConfig.authType, serviceName, yarnConfig.masterUrl)(logging) | ||
|
||
if (serviceDef != null) | ||
removeService() | ||
|
||
createService() | ||
} | ||
} | ||
override def createContainer( | ||
unusedtid: TransactionId, | ||
unusedname: String, | ||
actionImage: ExecManifest.ImageName, | ||
unuseduserProvidedImage: Boolean, | ||
unusedmemory: ByteSize, | ||
unusedcpuShares: Int)(implicit config: WhiskConfig, logging: Logging): Future[Container] = { | ||
implicit val timeout: Timeout = Timeout(containerStartTimeoutMS.milliseconds) | ||
|
||
//First send the create command to YARN, then with a different actor, wait for the container to be ready | ||
ask(yarnComponentActors(actionImage), CreateContainerAsync).flatMap(_ => | ||
ask(YARNContainerInfoActors(actionImage), GetContainerInfo(yarnComponentActors(actionImage))).mapTo[Container]) | ||
} | ||
override def cleanup(): Unit = { | ||
removeService() | ||
yarnComponentActors foreach { case (k, v) => actorSystem.stop(v) } | ||
YARNContainerInfoActors foreach { case (k, v) => actorSystem.stop(v) } | ||
} | ||
def createService(): Unit = { | ||
logging.info(this, "Creating Service with images: " + images.map(i => i.publicImageName).mkString(", ")) | ||
|
||
val componentList = images | ||
.map( | ||
i => | ||
ComponentDefinition( | ||
i.name.replace('.', '-'), //name must be [a-z][a-z0-9-]* | ||
Some(0), //start with zero containers | ||
Some(runCommand), | ||
Option.empty, | ||
Some(ArtifactDefinition(i.publicImageName, "DOCKER")), | ||
Some(ResourceDefinition(yarnConfig.cpus, yarnConfig.memory)), | ||
Some(ConfigurationDefinition(Map(("YARN_CONTAINER_RUNTIME_DOCKER_RUN_OVERRIDE_DISABLE", "true")))), | ||
List[String]())) | ||
.toList | ||
|
||
//Add kerberos def if necessary | ||
var kerberosDef: Option[KerberosPrincipalDefinition] = None | ||
if (yarnConfig.authType.equals(YARNRESTUtil.KERBEROSAUTH)) | ||
kerberosDef = Some( | ||
KerberosPrincipalDefinition(Some(yarnConfig.kerberosPrincipal), Some(yarnConfig.kerberosKeytab))) | ||
|
||
val service = ServiceDefinition( | ||
Some(serviceName), | ||
Some(version), | ||
Some(description), | ||
Some("STABLE"), | ||
Some(yarnConfig.queue), | ||
componentList, | ||
kerberosDef) | ||
|
||
//Submit service | ||
val response = | ||
YARNRESTUtil.submitRequestWithAuth( | ||
yarnConfig.authType, | ||
HttpMethods.POST, | ||
s"${yarnConfig.masterUrl}/app/v1/services", | ||
service.toJson.compactPrint) | ||
|
||
//Handle response | ||
response match { | ||
case httpresponse(StatusCodes.OK, content) => | ||
logging.info(this, s"Service submitted. Response: $content") | ||
|
||
case httpresponse(StatusCodes.Accepted, content) => | ||
logging.info(this, s"Service submitted. Response: $content") | ||
|
||
case httpresponse(_, _) => YARNRESTUtil.handleYARNRESTError(logging) | ||
} | ||
|
||
//Wait for service start (up to serviceStartTimeoutMS milliseconds) | ||
var started = false | ||
var retryCount = 0 | ||
val maxRetryCount = serviceStartTimeoutMS / retryWaitMS | ||
while (!started && retryCount < maxRetryCount) { | ||
val serviceDef = | ||
YARNRESTUtil.downloadServiceDefinition(yarnConfig.authType, serviceName, yarnConfig.masterUrl)(logging) | ||
|
||
if (serviceDef == null) { | ||
logging.info(this, "Service not found yet") | ||
Thread.sleep(retryWaitMS) | ||
} else { | ||
serviceDef.state.getOrElse(None) match { | ||
case "STABLE" | "STARTED" => | ||
logging.info(this, "YARN service achieved stable state") | ||
started = true | ||
|
||
case state => | ||
logging.info( | ||
this, | ||
s"YARN service is not in stable state yet ($retryCount/$maxRetryCount). Current state: $state") | ||
Thread.sleep(retryWaitMS) | ||
} | ||
} | ||
retryCount += 1 | ||
} | ||
if (!started) | ||
throw new Exception(s"After ${serviceStartTimeoutMS}ms YARN service did not achieve stable state") | ||
} | ||
def removeService(): Unit = { | ||
SamHjelmfelt marked this conversation as resolved.
Show resolved
Hide resolved
|
||
val response: httpresponse = | ||
YARNRESTUtil.submitRequestWithAuth( | ||
yarnConfig.authType, | ||
HttpMethods.DELETE, | ||
s"${yarnConfig.masterUrl}/app/v1/services/$serviceName", | ||
"") | ||
|
||
response match { | ||
case httpresponse(StatusCodes.OK, _) => | ||
logging.info(this, "YARN service Removed") | ||
|
||
case httpresponse(StatusCodes.NotFound, _) => | ||
logging.warn(this, "YARN service did not exist") | ||
|
||
case httpresponse(StatusCodes.BadRequest, _) => | ||
logging.warn(this, "YARN service did not exist") | ||
|
||
case httpresponse(_, _) => | ||
YARNRESTUtil.handleYARNRESTError(logging) | ||
} | ||
} | ||
} |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.