8000 Update Travis build/test to use Xenial and Docker 18 by jonpspri · Pull Request #4204 · apache/openwhisk · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Update Travis build/test to use Xenial and Docker 18 #4204

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 5 commits into from
Closed

Update Travis build/test to use Xenial and Docker 18 #4204

wants to merge 5 commits into from

Conversation

jonpspri
Copy link
Contributor
@jonpspri jonpspri commented Jan 7, 2019 •
edited
Loading

Description

The legacy Travis build for OpenWhisk uses a depricated Travis engine and Docker 12. While I know there are conversations around Docker 12 vs a later version, the use of the old Docker prevents use of certain good build features, namely Build Args for image selection and multi-stage builds.

This PR makes these changes:

  • Bumps the Travis build to Xenial Ubuntu (the latest supported), which includes Docker 18.
  • Patches Docker 18 service to listen on Port 4243 (TODO: let's get to shared sockets for everything)
  • Adds parameterization for limits.invocations.per.minute to reduce spurious system test failures - separate PR pending
  • Upgrades ephemeral CouchDB to apache/couchdb:2.3 (to avoid a shared-storage bug) - see also PR Bump ephemeral couchdb to v2.3 #4202
  • Changes how Ansible detects ansible uptime to use the ansible-cli in the ansible Docker image, rather than make assumptions about the ansible network protocol - PR Use redis-cli (via docker) to test status of Redis in ansible PING-PONG #4205
  • Fix a redundant re-run of unit tests - separate PR pending

I will track other PRs and rebase if they're committed.

Related issue and scope

  • I opened an issue to propose and discuss this change (#????)

My changes affect the following components

  • API
  • Controller
  • Message Bus (e.g., Kafka)
  • Loadbalancer
  • Invoker
  • Intrinsic actions (e.g., sequences, conductors)
  • Data stores (e.g., CouchDB)
  • Tests
  • Deployment
  • CLI
  • General tooling
  • Documentation

Types of changes

  • Bug fix (generally a non-breaking change which closes an issue).
  • Enhancement or new feature (adds new functionality).
  • Breaking change (a bug fix or enhancement which changes existing behavior).

Checklist:

  • I signed an Apache CLA.
  • I reviewed the style guides and followed the recommendations (Travis CI will check :).
  • I added tests to cover my changes.
  • My changes require further changes to the documentation.
  • I updated the documentation where necessary.

@rabbah
Copy link
Member
rabbah commented Feb 9, 2019

@jonpspri this is great to see - sorry it sat for some time and now needs to rebase. It looks like though there's a few PRs conflated in here are they all necessary to upgrade to xenial?

@rabbah rabbah added testing awaits-contributor The contributor needs to respond to comments from reviewer. labels Feb 9, 2019
@chetanmeh
Copy link
Member

Bumps the Travis build to Xenial Ubuntu (the latest supported), which includes Docker 18.
Patches Docker 18 service to listen on Port 4243 (TODO: let's get to shared sockets for everything)

The Travis build has now been moved to Xenial with #4683

@dgrove-oss
Copy link
Member

Should we close this as out-of-date?

@rabbah
Copy link
Member
rabbah commented Oct 17, 2019

👍

@dgrove-oss dgrove-oss closed this Oct 17, 2019
@jonpspri jonpspri deleted the pr-travis branch April 19, 2020 11:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
awaits-contributor The contributor needs to respond to comments from reviewer. testing
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@jonpspri @rabbah @chetanmeh @dgrove-oss
0