8000 [New scheduler] ActivationClientProxy by ningyougang · Pull Request #5119 · apache/openwhisk · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

[New scheduler] ActivationClientProxy #5119

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 7, 2021
Merged

[New scheduler] ActivationClientProxy #5119

merged 1 commit into from
Jun 7, 2021

Conversation

ningyougang
Copy link
Contributor
@ningyougang ningyougang commented May 27, 2021 •
edited
Loading

Description

  • FunctionPullContainerProxy creates ActivationClientProxy actor and sends StartClient to ActivationClientProxy
  • ActivationClientProxy creates akka grpc client after get StartClient message.
  • After created akka grpc client, ActivationClientProxy sends ClientCreationCompleted to FunctionPullContainerProxy.
  • FunctionPullContainerProxy goto(ClientCreated) FSM state and sends RequestActivation to ActivationClientProxy
  • ActivationClientProxy actor fetches activationMessage from scheduler side's MemroyQueue using akka grpc after got RequestActivation message.
  • ActivationClientProxy actor forwards the activationMessage to FunctionPullContainerProxy,
  • FunctionPullContainerProxy initializes/runs the activationMessage.

Related issue and scope

  • I opened an issue to propose and discuss this change (#????)

My changes affect the following components

  • API
  • Controller
  • Message Bus (e.g., Kafka)
  • Loadbalancer
  • Scheduler
  • Invoker
  • Intrinsic actions (e.g., sequences, conductors)
  • Data stores (e.g., CouchDB)
  • Tests
  • Deployment
  • CLI
  • General tooling
  • Documentation

Types of changes

  • Bug fix (generally a non-breaking change which closes an issue).
  • Enhancement or new feature (adds new functionality).
  • Breaking change (a bug fix or enhancement which changes existing behavior).

Checklist:

  • I signed an Apache CLA.
  • I reviewed the style guides and followed the recommendations (Travis CI will check :).
  • I added tests to cover my changes.
  • My changes require further changes to the documentation.
  • I updated the documentation where necessary.

@ningyougang
Copy link
Contributor Author

After this pr #5113 merged, i will do rebase operation.

@ningyougang ningyougang self-assigned this May 27, 2021
@codecov-commenter
Copy link
codecov-commenter commented May 27, 2021 •
edited
Loading

Codecov Report

Merging #5119 (a5853af) into master (0b2d2ab) will decrease coverage by 5.72%.
The diff coverage is 75.72%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #5119      +/-   ##
==========================================
- Coverage   81.50%   75.77%   -5.73%     
==========================================
  Files         219      227       +8     
  Lines       11775    12195     +420     
  Branches      506      515       +9     
==========================================
- Hits         9597     9241     -356     
- Misses       2178     2954     +776
Impacted Files Coverage Δ
.../core/containerpool/v2/ActivationClientProxy.scala 73.64% <73.64%> (ø)
...sk/core/scheduler/grpc/ActivationServiceImpl.scala 71.42% <87.50%> (-16.58%) ⬇️
...la/org/apache/openwhisk/common/TransactionId.scala 94.38% <100.00%> (+0.06%) ⬆️
...core/database/cosmosdb/RxObservableImplicits.scala 0.00% <0.00%> (-100.00%) ⬇️
...ore/database/cosmosdb/cache/CacheInvalidator.scala 0.00% <0.00%> (-100.00%) ⬇️
...e/database/cosmosdb/cache/ChangeFeedConsumer.scala 0.00% <0.00%> (-100.00%) ⬇️
...core/database/cosmosdb/CosmosDBArtifactStore.scala 0.00% <0.00%> (-95.85%) ⬇️
...sk/core/database/cosmosdb/CosmosDBViewMapper.scala 0.00% <0.00%> (-93.90%) ⬇️
...tabase/cosmosdb/cache/CacheInvalidatorConfig.scala 0.00% <0.00%> (-92.31%) ⬇️
...enwhisk/connector/kafka/KamonMetricsReporter.scala 0.00% <0.00%> (-83.34%) ⬇️
... and 28 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0b2d2ab...a5853af. Read the comment docs.

@ningyougang
Implement ActivationClientProxy
a5853af 
ActivationClientProxy actor fetches activationMessage from scheudler side
using akka grpc, and forwards the activationMessage to its parent actor
FunctionPullContainerProxy actor.
@ningyougang ningyougang force-pushed the ActivationClientProxy branch from 5cfb27b to a5853af Compare June 3, 2021 07:19
@ningyougang ningyougang changed the title [WIP][New scheduler] ActivationClientProxy [New scheduler] ActivationClientProxy Jun 7, 2021
@ningyougang ningyougang removed the wip label Jun 7, 2021
@style95 style95 merged commit 99fb2c5 into apache:master Jun 7, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jiangpengcheng jiangpengcheng jiangpengcheng approved these changes

@style95 style95 style95 approved these changes

Assignees

@ningyougang ningyougang

Labels
scheduler
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@ningyougang @codecov-commenter @jiangpengcheng @style95
0