Fix build error #5123
Merged
Fix build error #5123
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@ningyougang thanks ! |
You are welcome. |
ddragosd
reviewed
Jun 7, 2021
| @@ -715,7 +714,7 @@ class FunctionPullingContainerProxy( | |||
| logging.info( | |||
| this, | |||
| s"This is the remaining container for ${data.action}. The container will stop after $warmedContainerKeepingTimeout.") | |||
| setTimer(KeepingTimeoutName, Remove, warmedContainerKeepingTimeout) | |||
| startSingleTimer(KeepingTimeoutName, Remove, warmedContainerKeepingTimeout) | |||
There was a problem hiding this comment.
startTimerAtFixedRate instead ?
There was a problem hiding this comment.
I checked the source code
def startTimerAtFixedRate(name: String, msg: Any, interval: FiniteDuration): Unit =
startTimer(name, msg, interval, FixedRateMode)
...
/** INTERNAL API */
@InternalApi
private[akka] case object FixedRateMode extends TimerMode {
override def repeat: Boolean = true
}
the method: startTimerAtFixedRate will invoke startTimer with repeat: true,
but for here, it is a one time timer,
So startSingleTimer is ok here.
| @@ -777,7 +776,7 @@ class FunctionPullingContainerProxy( | |||
| } | |||
| } | |||
| unstashAll() | |||
| case _ -> Paused => setTimer(IdleTimeoutName, StateTimeout, idleTimeout) | |||
| case _ -> Paused => startSingleTimer(IdleTimeoutName, StateTimeout, idleTimeout) | |||
There was a problem hiding this comment.
startTimerAtFixedRate instead ?
There was a problem hiding this comment.
| @@ -613,7 +612,7 @@ class FunctionPullingContainerProxy( | |||
| logging.info( | |||
| this, | |||
| s"Remain running activations ${runningActivations.keySet().toString()} when received ClientClosed") | |||
| setTimer(RunningActivationTimeoutName, ClientClosed, runningActivationTimeout) | |||
| startSingleTimer(RunningActivationTimeoutName, ClientClosed, runningActivationTimeout) | |||
There was a problem hiding this comment.
wondering if startTimerAtFixedRate should be used instead
There was a problem hiding this comment.
Codecov Report
@@ Coverage Diff @@
## master #5123 +/- ##
==========================================
+ Coverage 28.91% 29.91% +1.00%
==========================================
Files 219 228 +9
Lines 11775 12246 +471
Branches 506 519 +13
==========================================
+ Hits 3405 3664 +259
- Misses 8370 8582 +212
Continue to review full report at Codecov.
|
rabbah
approved these changes
Jun 7, 2021
21 tasks
307a1b3 to
156c2eb
Compare
jiangpengcheng
approved these changes
Jun 8, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fix build error, and the error is leaded by this pr: Upgrade to Akka 2.6.12: #5065
When i tested, forgot to rebase that pr.
Related issue and scope
My changes affect the following components
Types of changes
Checklist: