8000 chore: filter events to reconcile by CRD API version by leon-inf · Pull Request #8522 · apecloud/kubeblocks · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

chore: filter events to reconcile by CRD API version #8522

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Nov 29, 2024
Merged

chore: filter events to reconcile by CRD API version #8522

merged 2 commits into from
Nov 29, 2024

Conversation

leon-inf
Copy link
Contributor

No description provided.

@github-actions github-actions bot added the size/L Denotes a PR that changes 100-499 lines. label Nov 25, 2024
@leon-inf leon-inf added this to the Release 0.9.2 milestone Nov 25, 2024
@codecov Codecov
Copy link
codecov bot commented Nov 25, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 33.33333% with 8 lines in your changes missing coverage. Please review.

Project coverage is 64.99%. Comparing base (d1c20f4) to head (fc95641).
Report is 13 commits behind head on release-0.9.

Files with missing lines Patch % Lines
pkg/controllerutil/predicate.go 0.00% 7 Missing ⚠️
...rollers/experimental/nodecountscaler_controller.go 0.00% 1 Missing ⚠️
Additional details and impacted files 
@@               Coverage Diff               @@
##           release-0.9    #8522      +/-   ##
===============================================
+ Coverage        64.84%   64.99%   +0.14%     
===============================================
  Files              358      358              
  Lines            45523    45732     +209     
===============================================
+ Hits             29521    29725     +204     
- Misses           13374    13375       +1     
- Partials          2628     2632       +4
Flag Coverage Δ
unittests 64.99% <33.33%> (+0.14%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@leon-inf leon-inf marked this pull request as ready for review November 29, 2024 02:17
@apecloud-bot apecloud-bot added the approved PR Approved Test label Nov 29, 2024
@leon-inf leon-inf merged commit 6931535 into release-0.9 Nov 29, 2024
38 checks passed
@leon-inf leon-inf deleted the support/v1alpha1-api-version-filter branch November 29, 2024 09:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zjx20 zjx20 zjx20 approved these changes

@wangyelei wangyelei wangyelei approved these changes

@nayutah nayutah Awaiting requested review from nayutah

@ldming ldming Awaiting requested review from ldming

@heng4fun heng4fun Awaiting requested review from heng4fun

@free6om free6om Awaiting requested review from free6om

@Y-Rookie Y-Rookie Awaiting requested review from Y-Rookie Y-Rookie is a code owner

Assignees
No one assigned
Labels
approved PR Approved Test size/L Denotes a PR that changes 100-499 lines.
Projects
None yet
Milestone
Release 0.9.2
Development

Successfully merging this pull request may close these issues.
4 participants
@leon-inf @zjx20 @wangyelei @apecloud-bot
0