8000 fix: use update instead of patch to set pod's role by xuriwuyun · Pull Request #8871 · apecloud/kubeblocks · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

fix: use update instead of patch to set pod's role #8871

New issue
8000

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Feb 6, 2025
Merged

fix: use update instead of patch to set pod's role #8871

merged 3 commits into from
Feb 6, 2025

Conversation

xuriwuyun
Copy link
Contributor

No description provided.

@xuriwuyun xuriwuyun requested a review from a team as a code owner January 24, 2025 06:12
@github-actions github-actions bot added the size/S Denotes a PR that changes 10-29 lines. label Jan 24, 2025
@xuriwuyun xuriwuyun linked an issue Jan 24, 2025 that may be closed by this pull request
[BUG] After the restart of the KB controller, when processing the handleRoleChangedEvent event, a disorder issue occurs #8857
Closed
@xuriwuyun xuriwuyun changed the title fix: use update instand of patch to set pod's role fix: use update instead of patch to set pod's role Jan 24, 2025
@github-actions github-actions bot added size/M Denotes a PR that changes 30-99 lines. and removed size/S Denotes a PR that changes 10-29 lines. labels Jan 24, 2025
@codecov Codecov
Copy link
codecov bot commented Jan 24, 2025 •
edited
Loading

Codecov Report

Attention: Patch coverage is 77.77778% with 2 lines in your changes missing coverage. Please review.

Project coverage is 64.48%. Comparing base (8cf92c7) to head (0746057).
Report is 3 commits behind head on release-0.9.

Files with missing lines Patch % Lines
...g/controller/instanceset/pod_role_event_handler.go 77.77% 2 Missing ⚠️
Additional details and impacted files 
@@               Coverage Diff               @@
##           release-0.9    #8871      +/-   ##
===============================================
+ Coverage        64.40%   64.48%   +0.07%     
===============================================
  Files              359      359              
  Lines            46457    46471      +14     
===============================================
+ Hits             29922    29968      +46     
+ Misses           13841    13816      -25     
+ Partials          2694     2687       -7
Flag Coverage Δ
unittests 64.48% <77.77%> (+0.07%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@apecloud-bot apecloud-bot added the approved PR Approved Test label Feb 6, 2025
@xuriwuyun xuriwuyun merged commit 61da3a8 into release-0.9 Feb 6, 2025
36 checks passed
@xuriwuyun xuriwuyun deleted the bugfix/handle_role_event branch February 6, 2025 08:44
@github-actions github-actions bot added this to the Release 0.9.3 milestone Feb 6, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zjx20 zjx20 zjx20 approved these changes

Assignees
No one assigned
Labels
approved PR Approved Test size/M Denotes a PR that changes 30-99 lines.
Projects
None yet
Milestone
Release 0.9.3
3 participants
@xuriwuyun @zjx20 @apecloud-bot
0