8000 feat: a new pod naming rule for instanceset by cjc7373 · Pull Request #9292 · apecloud/kubeblocks · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

feat: a new pod naming rule for instanceset #9292

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 39 commits into from
Jun 16, 2025
Merged

feat: a new pod naming rule for instanceset #9292

merged 39 commits into from
Jun 16, 2025

Conversation

cjc7373
Copy link
Contributor
@cjc7373 cjc7373 commented Apr 23, 2025 •
edited
Loading

Changes related to OpsRequest will be implemented in another PR.

@cjc7373 cjc7373 changed the title feat: a new pod naming rule feat: a new pod naming rule for instanceset Apr 23, 2025
@github-actions github-actions bot added the size/XXL Denotes a PR that changes 1000+ lines. label Apr 23, 2025
@cjc7373 cjc7373 force-pushed the feature/new-pod-naming-rule branch from 8b49f68 to e7a89c9 Compare April 24, 2025 07:03
leon-inf
leon-inf reviewed Apr 25, 2025
View reviewed changes
leon-inf
leon-inf reviewed Apr 25, 2025
View reviewed changes
leon-inf
leon-inf reviewed Apr 25, 2025
View reviewed changes
@cjc7373 cjc7373 force-pushed the feature/new-pod-naming-rule branch from e7a89c9 to 15893fa Compare May 13, 2025 08:53
@leon-inf leon-inf mentioned this pull request May 20, 2025
Merged
@cjc7373 cjc7373 force-pushed the feature/new-pod-naming-rule branch from 15893fa to ff58e24 Compare May 21, 2025 06:47
cjc7373 added 9 commits May 21, 2025 15:55
@cjc7373
wip
781814c 
old behavior

migrate to new api

validation

crd generation

add some tests

cleanup

header

split validation rules for different pod name builder

cleanup

typo

comment

migrate some usage of GenerateAllInstanceNames to new api

wip

manifest
@cjc7373
fix some tests
9e0f0c4
@cjc7373
cleanup
082d494
@cjc7373
fix more tests
ed16b25
@cjc7373
fix
0ecdae1
@cjc7373
fix more tests
d3b85f7
@cjc7373
loose ordinal constriant
d00c241
@cjc7373
rebase main, resolve conflicts
74fac46
@cjc7373
use map for InstanceStatus
41c2834
@cjc7373 cjc7373 force-pushed the feature/new-pod-naming-rule branch from ff58e24 to 41c2834 Compare May 21, 2025 08:33
@codecov Codecov
Copy link
codecov bot commented May 21, 2025 •
edited
Loading

Codecov Report

Attention: Patch coverage is 70.32020% with 241 lines in your changes missing coverage. Please review.

Project coverage is 59.58%. Comparing base (b1d121d) to head (975c540).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
...ontroller/instanceset/instancetemplate/template.go 66.94% 33 Missing and 7 partials ⚠️
...roller/instanceset/instancetemplate/compression.go 29.09% 37 Missing and 2 partials ⚠️
.../instanceset/instancetemplate/name_builder_flat.go 80.30% 30 Missing and 9 partials ⚠️
pkg/controller/component/workload_utils.go 44.64% 27 Missing and 4 partials ⚠️
...troller/instanceset/instancetemplate/validation.go 70.00% 9 Missing and 6 partials ⚠️
...stanceset/instancetemplate/name_builder_default.go 89.16% 9 Missing and 4 partials ⚠️
...kg/controller/instanceset/reconciler_validation.go 0.00% 12 Missing ⚠️
pkg/controller/component/available.go 30.76% 9 Missing ⚠️
...controller/instanceset/instancetemplate/ordinal.go 78.04% 6 Missing and 3 partials ⚠️
.../component/transformer_component_load_resources.go 62.50% 4 Missing and 2 partials ⚠️
... and 8 more
Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #9292      +/-   ##
==========================================
+ Coverage   59.37%   59.58%   +0.21%     
==========================================
  Files         493      500       +7     
  Lines       53945    54354     +409     
==========================================
+ Hits        32029    32386     +357     
- Misses      19011    19059      +48     
- Partials     2905     2909       +4
Flag Coverage Δ
unittests 59.58% <70.32%> (+0.21%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@leon-inf leon-inf added this to the Release 1.1.0 milestone May 21, 2025
@cjc7373 cjc7373 marked this pull request as ready for review May 22, 2025 05:58
@cjc7373 cjc7373 requested a review from a team as a code owner May 22, 2025 05:58
leon-inf
leon-inf reviewed May 22, 2025
View reviewed changes
@leon-inf leon-inf force-pushed the feature/new-pod-naming-rule branch 2 times, most recently from 07cc87b to a17d208 Compare June 12, 2025 02:54
@leon-inf leon-inf force-pushed the feature/new-pod-naming-rule branch from a17d208 to c0bd8a1 Compare June 12, 2025 03:09
@leon-inf
Copy link
Contributor

/nopick

@apecloud-bot apecloud-bot added the nopick Not auto cherry-pick when PR merged label Jun 13, 2025
zjx20
zjx20 reviewed Jun 13, 2025
View reviewed changes
@leon-inf leon-inf force-pushed the feature/new-pod-naming-rule branch from cc75390 to e348661 Compare June 14, 2025 03:03
@apecloud-bot apecloud-bot added the approved PR Approved Test label Jun 14, 2025
6D40
@apecloud-bot apecloud-bot removed the approved PR Approved Test label Jun 16, 2025
@leon-inf
Copy link
Contributor

/approve

@apecloud-bot apecloud-bot added the approved PR Approved Test label Jun 16, 2025
@leon-inf leon-inf force-pushed the feature/new-pod-naming-rule branch from 760ffdc to 975c540 Compare June 16, 2025 03:04
@apecloud-bot apecloud-bot removed the approved PR Approved Test label Jun 16, 2025
@apecloud-bot apecloud-bot added the approved PR Approved Test label Jun 16, 2025
@leon-inf
Copy link
Contributor

/approve

@leon-inf leon-inf merged commit 8e34326 into main Jun 16, 2025
42 checks passed
@leon-inf leon-inf deleted the feature/new-pod-naming-rule branch June 16, 2025 03:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zjx20 zjx20 zjx20 approved these changes

@leon-inf leon-inf leon-inf approved these changes

@apecloud-bot apecloud-bot apecloud-bot approved these changes

Assignees
No one assigned
Labels
approved PR Approved Test nopick Not auto cherry-pick when PR merged size/XXL Denotes a PR that changes 1000+ lines.
Projects
None yet
Milestone
Release 1.1.0
Development

Successfully merging this pull request may close these issues.
4 participants
@cjc7373 @leon-inf @zjx20 @apecloud-bot
0