8000 feat: export user-defined environment variables to lifecycle actions by Tanc010 · Pull Request #9514 · apecloud/kubeblocks · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

feat: export user-defined environment variables to lifecycle actions #9514

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 9, 2025
Merged

feat: export user-defined environment variables to lifecycle actions #9514

merged 1 commit into from
Jul 9, 2025

Conversation

Tanc010
Copy link
Contributor
@Tanc010 Tanc010 commented Jul 4, 2025

After adding environment variables (env) to the componentSpecs in the cluster, I noticed that the kbagent container in the pod did not contain the env variables I defined. Upon reviewing the source code, I found that the kbagent container is created after the environment variables are merged, and therefore does not utilize the env variables I specified.

@Tanc010 Tanc010 requested a review from a team as a code owner July 4, 2025 03:18
@CLAassistant
Copy link
CLAassistant commented Jul 4, 2025 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

@apecloud-bot
Copy link
Collaborator

Auto Cherry-pick Instructions

Usage:
  - /nopick: Not auto cherry-pick when PR merged.
  - /pick: release-x.x [release-x.x]: Auto cherry-pick to the specified branch when PR merged.

Example:
  - /nopick
  - /pick release-1.0

@github-actions github-actions bot added the size/XS Denotes a PR that changes 0-9 lines. label Jul 4, 2025
@apecloud-bot apecloud-bot added the pre-approve Fork PR Pre Approve Test label Jul 4, 2025
@apecloud-bot apecloud-bot added pre-approve Fork PR Pre Approve Test and removed pre-approve Fork PR Pre Approve Test labels Jul 8, 2025
@dongjiang1989
Copy link

/pick release-1.0

@apecloud-bot apecloud-bot added the pick-1.0 Auto cherry-pick to release-1.0 when PR merged label Jul 9, 2025
dongjiang1989
dongjiang1989 reviewed Jul 9, 2025
View reviewed changes
Copy link
@dongjiang1989 dongjiang1989 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@leon-inf leon-inf changed the title User-defined environment variables are not supported in the kbagent container. feat: export user-defined environment variables to lifecycle actions Jul 9, 2025
@leon-inf
Copy link 8000
Contributor
leon-inf commented Jul 9, 2025

/approve

@leon-inf leon-inf merged commit 795e3b5 into apecloud:main Jul 9, 2025
31 of 35 checks passed
@github-actions github-actions bot added this to the Release 0.9.4 milestone Jul 9, 2025
@apecloud-bot
Copy link
Collaborator

/cherry-pick release-1.0

@apecloud-bot
Copy link
Collaborator

🤖 says: cherry pick action finished successfully 🎉!
See: https://github.com/apecloud/kubeblocks/actions/runs/16159175428

apecloud-bot pushed a commit that referenced this pull request Jul 9, 2025
@Tanc010 @apecloud-bot
feat: export user-defined environment variables to lifecycle actions (#…
c88ce6e 
…9514)

(cherry picked from commit 795e3b5)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dongjiang1989 dongjiang1989 dongjiang1989 left review comments

@leon-inf leon-inf leon-inf approved these changes

@apecloud-bot apecloud-bot apecloud-bot approved these changes

Assignees
No one assigned
Labels
pick-1.0 Auto cherry-pick to release-1.0 when PR merged pre-approve Fork PR Pre Approve Test size/XS Denotes a PR that changes 0-9 lines.
Projects
None yet
Milestone
Release 0.9.4
Development

Successfully merging this pull request may close these issues.
5 participants
@Tanc010 @CLAassistant @apecloud-bot @dongjiang1989 @leon-inf
0