8000 fix: use component label for pod ownership check in shard switchover by shanshanying · Pull Request #9524 · apecloud/kubeblocks · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

fix: use component label for pod ownership check in shard switchover #9524

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jul 9, 2025
Merged

fix: use component label for pod ownership check in shard switchover #9524

merged 2 commits into from
Jul 9, 2025

Conversation

shanshanying
Copy link
Contributor

@shanshanying shanshanying requested a review from a team as a code owner July 9, 2025 06:42
@apecloud-bot
Copy link
Collaborator

Auto Cherry-pick Instructions

Usage:
  - /nopick: Not auto cherry-pick when PR merged.
  - /pick: release-x.x [release-x.x]: Auto cherry-pick to the specified branch when PR merged.

Example:
  - /nopick
  - /pick release-1.0

@github-actions github-actions bot added the size/XS Denotes a PR that changes 0-9 lines. label Jul 9, 2025
@shanshanying shanshanying added the pick-1.0 Auto cherry-pick to release-1.0 when PR merged label Jul 9, 2025
@apecloud-bot apecloud-bot added the approved PR Approved Test label Jul 9, 2025
@codecov Codecov
Copy link
codecov bot commented Jul 9, 2025 •
edited
Loading

Codecov Report

Attention: Patch coverage is 0% with 7 lines in your changes missing coverage. Please review.

Project coverage is 59.69%. Comparing base (1079425) to head (fd3ebc2).
Report is 2 commits behind head on main.

Files with missing lines Patch % Lines
pkg/dataprotection/restore/utils.go 0.00% 6 Missing ⚠️
pkg/operations/switchover.go 0.00% 0 Missing and 1 partial ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #9524      +/-   ##
==========================================
+ Coverage   59.57%   59.69%   +0.11%     
==========================================
  Files         518      518              
  Lines       55754    55754              
==========================================
+ Hits        33217    33282      +65     
+ Misses      19538    19482      -56     
+ Partials     2999     2990       -9
Flag Coverage Δ
unittests 59.69% <0.00%> (+0.11%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@wusai80
refactor: move GetComponentNameFromObj to restore utils as private fu…
fd3ebc2 
…nction

Move GetComponentNameFromObj from pkg/controller/component/component.go to
pkg/dataprotection/restore/utils.go as a private function getComponentNameFromObj.
@shanshanying shanshanying requested review from ldming and zjx20 as code owners July 9, 2025 07:56
@apecloud-bot apecloud-bot removed the approved PR Approved Test label Jul 9, 2025
@github-actions github-actions bot added size/S Denotes a PR that changes 10-29 lines. and removed size/XS Denotes a PR that changes 0-9 lines. labels Jul 9, 2025
@apecloud-bot apecloud-bot added the approved PR Approved Test label Jul 9, 2025
@shanshanying shanshanying merged commit 4d510f8 into main Jul 9, 2025
40 checks passed
@shanshanying shanshanying deleted the bugfix/swithcover-use-componentname-for-shard branch July 9, 2025 08:32
@github-actions github-actions bot added this to the Release 0.9.4 milestone Jul 9, 2025
@apecloud-bot
Copy link
Collaborator

/cherry-pick release-1.0

@apecloud-bot
Copy link
Collaborator

🤖 says: cherry pick action finished successfully 🎉!
See: https://github.com/apecloud/kubeblocks/actions/runs/16164399937

apecloud-bot pushed a commit that referenced this pull request Jul 9, 2025
@shanshanying @wusai80 @apecloud-bot
fix: use component label for pod ownership check in shard switchover (#…
c571e64 
…9524)

Co-authored-by: wusai80 <wusai80@gmail.com>
(cherry picked from commit 4d510f8)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wangyelei wangyelei wangyelei approved these changes

@leon-inf leon-inf leon-inf approved these changes

@ldming ldming Awaiting requested review from ldming ldming is a code owner

@zjx20 zjx20 Awaiting requested review from zjx20 zjx20 is a code owner

Assignees
No one assigned
Labels
approved PR Approved Test pick-1.0 Auto cherry-pick to release-1.0 when PR merged size/S Denotes a PR that changes 10-29 lines.
Projects
None yet
Milestone
Release 0.9.4
Development

Successfully merging this pull request may close these issues.

[BUG] the pod not belongs to the component when switchover a shard comonent
5 participants
@shanshanying @apecloud-bot @wangyelei @leon-inf @wusai80
0