8000 feat: adapt ops with new api by wangyelei · Pull Request #467 · apecloud/kbcli · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

feat: adapt ops with new api #467

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 7 commits into from
Oct 18, 2024
Merged

feat: adapt ops with new api #467

merged 7 commits into from
Oct 18, 2024

Conversation

wangyelei
Copy link
Contributor

No description provided.

@wangyelei wangyelei linked an issue Oct 17, 2024 that may be closed by this pull request
[Improvement] kbcli supports to adapt ops with 1.0 api #432
Closed
@github-actions github-actions bot added the size/XXL Denotes a PR that changes 1000+ lines. label Oct 17, 2024
@codecov-commenter
Copy link

Codecov Report

Attention: Patch coverage is 48.86650% with 203 lines in your changes missing coverage. Please review.

Project coverage is 42.02%. Comparing base (15d1aac) to head (965df66).

Files with missing lines Patch % Lines
pkg/cmd/cluster/operations.go 57.28% 67 Missing and 21 partials ⚠️
pkg/util/flags/flags.go 16.98% 43 Missing and 1 partial ⚠️
pkg/cmd/cluster/describe_ops.go 61.90% 33 Missing and 7 partials ⚠️
pkg/cluster/helper.go 0.00% 17 Missing ⚠️
pkg/util/flags/schema_to_flags.go 0.00% 14 Missing ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##             main     #467      +/-   ##
==========================================
+ Coverage   41.61%   42.02%   +0.41%     
==========================================
  Files         165      165              
  Lines       22904    22923      +19     
==========================================
+ Hits         9531     9634     +103     
+ Misses      12257    12150     -107     
- Partials     1116     1139      +23
Flag Coverage Δ
unittests 42.02% <48.86%> (+0.41%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@wangyelei wangyelei force-pushed the feature/adapt_new_ops_api branch from 6b28b9a to 87284fa Compare October 18, 2024 03:21
@wangyelei wangyelei merged commit ce3daf9 into main Oct 18, 2024
5 checks passed
@wangyelei wangyelei deleted the feature/adapt_new_ops_api branch October 18, 2024 06:02
@github-actions github-actions bot added this to the Release 1.0 milestone Oct 18, 2024
wangyelei added a commit that referenced this pull request Oct 18, 2024
@wangyelei
feat: adapt ops with new api (#467)
48085a6 
Co-authored-by: wangyelei <wangyelei@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ldming ldming ldming approved these changes

@nayutah nayutah Awaiting requested review from nayutah nayutah is a code owner

@heng4fun heng4fun Awaiting requested review from heng4fun heng4fun is a code owner

@free6om free6om Awaiting requested review from free6om

@leon-inf leon-inf Awaiting requested review from leon-inf leon-inf is a code owner

@1aal 1aal Awaiting requested review from 1aal 1aal is a code owner

Assignees
No one assigned
Labels
size/XXL Denotes a PR that changes 1000+ lines.
Projects
None yet
Milestone
Release 1.0
Development

Successfully merging this pull request may close these issues.

[Improvement] kbcli supports to adapt ops with 1.0 api
3 participants
@wangyelei @codecov-commenter @ldming
0