Rover command for multiple subgraph publish #2473
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@samaanghani: Thank you for submitting a pull request! Before we can merge it, you'll need to sign the Apollo Contributor License Agreement here: https://contribute.apollographql.com/ |
✅ Docs preview readyThe preview is ready to be viewed. View the preview File Changes 0 new, 2 changed, 0 removedBuild ID: 5bd099cfa4ac06c17cb200fe URL: https://www.apollographql.com/docs/deploy-preview/5bd099cfa4ac06c17cb200fe |
b5a3fe0 to
d711f72
Compare
d711f72 to
4c5cb40
Compare
pubmodmatt
reviewed
Apr 8, 2025
Comment on lines
80
to
+81
| use serde_json::json; | ||
| use super::*; |
There was a problem hiding this comment.
This change is causing a lint failure.
Suggested change
| use serde_json::json; | |
| use super::*; | |
| use super::*; | |
| use serde_json::json; |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding new command to accept JSON manifest to publish multiple subgraphs at the same time.
[Testing]
Validated that this works through manual testing, added unit testing. Updated platform API with additional field
subgraphsUpdatedthat is required.[Release]
[TODO]
A follow up PR will address additional refactoring, and add to e2e testing suite.
Will follow up with tooling team to get this started and follow their release process.