feat(rover)init: correctly capitalize TypeScript #2579
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Docs preview has no changesThe preview was not built because there were no changes. Build ID: aa49ceac6e8db4eb11e5babb |
tayrrible
approved these changes
May 9, 2025
sanchezdale
approved these changes
May 9, 2025
Merged
tayrrible
added a commit
that referenced
this pull request
May 13, 2025
<!--
First, 🌠 thank you 🌠 for taking the time to consider a contribution to
Apollo!
Here are some important details to follow:
* ⏰ Your time is important
To save your precious time, if the contribution you are making will
take more than an hour, please make sure it has been discussed in an
issue first. This is especially true for feature requests!
* 💡 Features
Feature requests can be created and discussed within a GitHub Issue.
Be sure to search for existing feature requests (and related issues!)
prior to opening a new request. If an existing issue covers the need,
please upvote that issue by using the 👍 emote, rather than opening a
new issue.
* 🕷 Bug fixes
These can be created and discussed in this repository. When fixing a
bug,
please _try_ to add a test which verifies the fix. If you cannot, you
should
still submit the PR but we may still ask you (and help you!) to create a
test.
* 📖 Contribution guidelines
Follow https://github.com/apollographql/rover/blob/HEAD/CONTRIBUTING.md
when submitting a pull request. Make sure existing tests still pass, and
add
tests for all new behavior.
* ✏️ Explain your pull request
Describe the big picture of your changes here to communicate to what
your pull request is meant to accomplish. Provide 🔗 links 🔗 to
associated issues!
We hope you will find this to be a positive experience! Open source
contribution can be intimidating and we hope to alleviate that pain as
much
as possible. Without following these guidelines, you may be missing
context
that can help you succeed with your contribution, which is why we
encourage
discussion first. Ultimately, there is no guarantee that we will be able
to
merge your pull-request, but by following these guidelines we can try to
avoid disappointment.
-->
## 🚀 Features
- **Add support for templates in the ```rover init``` command**
This adds support for templates in the `rover init` command. You can now
select a template to use when creating a new graph.
### PRs Included
- [#2562](#2562) -
feat(init): Adds `init` flag to default features - @tayrrible
- [#2560](#2560) -
feat(rover): Makes starter file configurable during project creation -
@gocamille
- [#2559](#2559) -
feat(rover): Adds `start_point_file` to specify what file to use in
output - @sanchezdale
- [#2558](#2558) -
feat(rover): Displays template commands during init flow if one exists -
@gocamille
- [#2557](#2557) -
feat(init): Adds template selector for "recommended libraries" option -
@tayrrible
- [#2545](#2545) - Modifies
existing logic to fetch from the new github service latest released
version - @sanchezdale
- [#2542](#2542) -
refactor(init): Improves authentication error handling in init command -
@gocamille
- [#2539](#2539) -
refactor(init): Improves error handling for graphId step, improve and
code structure of rover init - @gocamille
- [#2567](#2567) -
feat(rover): init flow - update project creation copy for accuracy -
@gocamille
- [#2568](#2568) -
feat(init): Always show template selector for recommended libraries flow
- @tayrrible
- [#2570](#2570) -
feat(init): Updating error message for non-empty directory - @tayrrible
- [#2572](#2572) - Improving
file display in tree mode - @sanchezdale
- [#3573](#2573) -
feat(rover)init: allow multiple commands to be printed for graph
creation message - @gocamille
- [#2575](#2575) -
feat(rover): updating file display to show success and remove extra
chars for now - @tayrrible
- [#2577](#2577) - feat(auth)
Using shortlinks for hyperlinks to api keys - @tayrrible
- [#7578](#2578) - adding
template doc to docs list - @sanchezdale
- [#2579](#2579) -
feat(rover)init: correctly capitalize TypeScript - @gocamille
- [#2580](#2580) -
feat(rover)init: Update Next steps section in project creation message -
@gocamille
- [#2582](#2582) - feat(init)
Moving to using env var vs flag for graph ref when prompting user to run
dev command - @tayrrible
- [#2590](#2590) -
feat(init): Fixing command spacing for final display message and
removing extra char from file list - @tayrrible
## 🐛 Fixes
- [#2555](#2555) - fix(init):
Properly handles default graph ID acceptance - @gocamille
- [#2566](#2566) - fix(init):
Display command in project creation message for typescript template -
@gocamille
- [#2571](#2571) - fix(init)
Stripping all non-alphanumeric chars from graph id during generation and
adding test - @tayrrible
## 🛠 Maintenance
- [#2556](#2556) -
feat(init): Standardizes visual output and display messages for init
command - @tayrrible
- [#2552](#2552) -
chore(all): Adds clippy::panic lint across all crates - @gocamille
- [#2550](#2550) -
chore(deps): Updates dependency apollographql/router to v1.61.5 -
@renovate
- [#2536](#2536) -
feature(init): Removes init feature flag usage - @tayrrible
- [#2553](#2553) -
chore(deps): update dependency apollographql/router to v2.2.0 -
@renovate
- [#2565](#2565) -
chore(deps): update dependency apollographql/router to v1.61.6 -
@renovate
- [#2581](#2581) - update
language-server to 0.4.1 - @Jephuff
## 📚 Documentation
- [#2551](#2551) - Adds `pq
publish` into docs - @lleadbet
- [#2549](#2549) - Updates
doc about key used with graph ref - @pubmodmatt
- [#2541](#2541) - Update
`rover init` resources - @Meschreiber
- [#2540](#2540) - Uses
`actions/checkout@v4` in GitHub Actions example workflows - @DaleSeo
- [#2569](#2569) - docs: Set
the APOLLO_VCS_BRANCH environment variable in GitHub Actions - @DaleSeo
- [#2561](#2561) - docs:
rover init v.30 update - @Meschreiber
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR ensures consistent capitalization of "TypeScript" throughout the codebase. The correct capitalization is "TypeScript" (with a capital 'S'), which is the official name of the language.
Changes
template_fetcher.rsJSON stringsoptions/template.rsenum and match statementsAdditional Notes
This PR must be merged with the associated PR in the
rover-init-startersrepository: apollographql/rover-init-starters#37