8000 fix(init): Better error handling for graph creation permission errors by tayrrible · Pull Request #2603 · apollographql/rover · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

fix(init): Better error handling for graph creation permission errors #2603

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
May 23, 2025

Conversation

tayrrible
Copy link
Contributor

Before, we were swallowing most errors returned from the API and returning a generic "catch-all" error instead.

Now, we are checking the error for permissions-related errors to return appropriate messaging and passing all other error results through to the user.

Adding a tracing log for errors encountered during graph creation to help with debugging.

Also removing suggestion copy regarding creating a graph in Studio.

@tayrrible tayrrible requested review from a team as code owners May 23, 2025 14:36
@tayrrible tayrrible added the fix 🩹 fixes a bug label May 23, 2025
@tayrrible tayrrible added this to the vNext milestone May 23, 2025
@svc-apollo-docs
Copy link
Collaborator
svc-apollo-docs commented May 23, 2025

✅ Docs preview ready

The preview is ready to be viewed. View the preview

File Changes

0 new, 1 changed, 0 removed
* graphos/routing/(latest)/observability/debugging-subgraph-requests.mdx

Build ID: 169b12c31342c1bbc0b6bcfb

URL: https://www.apollographql.com/docs/deploy-preview/169b12c31342c1bbc0b6bcfb

@tayrrible tayrrible merged commit 50a76ce into main May 23, 2025
32 checks passed
@tayrrible tayrrible deleted the taylor/better-permission-error-handling-for-init branch May 23, 2025 15:00
@tayrrible tayrrible mentioned this pull request May 28, 2025
tayrrible added a commit that referenced this pull request May 28, 2025
# [0.31.3] - 2025-05-28

## 🐛 Fixes

- **Eliminate unnecessary warnings on rover dev startup - @pubmodmatt PR
#2604**
- **Improved error handling for graph creations through rover init -
@tayrrible PR #2603**
@tayrrible tayrrible mentioned this pull request May 28, 2025
tayrrible added a commit that referenced this pull request May 28, 2025
# [0.31.3] - 2025-05-28
## 🐛 Fixes
- **Eliminate unnecessary warnings on rover dev startup - @pubmodmatt PR
#2604**
- **Improved error handling for graph creations through rover init -
@tayrrible PR #2603**
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
fix 🩹 fixes a bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants
0