8000 [HELP-WANTED] Adding Support for More OAuth Providers · Issue #5 · appwrite/appwrite · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

[HELP-WANTED] Adding Support for More OAuth Providers #5

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
mixty1 opened this issue Sep 3, 2019 · 55 comments
Closed

[HELP-WANTED] Adding Support for More OAuth Providers #5

mixty1 opened this issue Sep 3, 2019 · 55 comments
Labels
enhancement New feature or request good first issue Good for newcomers hacktoberfest Issues that can win you some cool swags! help wanted Extra attention is needed

Comments

@mixty1
Copy link
mixty1 commented Sep 3, 2019

Is it possible to add my own auth provider, for example, I need to add vk.com or maybe this feature will be added later?
@eldadfux
Copy link
Member
eldadfux commented Sep 3, 2019

Hi @mixty1, currently have only 3 working OAuth providers working (facebook, github and linkedin).

I am working right now to simplify the process of adding new providers and I am going to write a detailed tutorial explaining how to add new providers to our source code.

This is an area where I really hope the community will give a hand, as we need to support as many major OAuth providers as possible.

@eldadfux eldadfux added enhancement New feature or request help wanted Extra attention is needed labels Sep 3, 2019
@eldadfux eldadfux changed the title Custom auth provider Adding Support for More OAuth Providers Sep 3, 2019
@eldadfux
Copy link
Member
eldadfux commented Sep 4, 2019 •
edited
Loading

OK, I have added a short tutorial that explains the steps required to add a new OAuth provider to the project.

Still need to change some things regarding the way we add new provider logos, but should be enough to get started.

The tutorial is here:
https://github.com/appwrite/appwrite/blob/master/docs/tutorials/add-oauth-provider.md

And should followed after reading our new contribution guide:
https://github.com/appwrite/appwrite/blob/master/CONTRIBUTING.md

And the code of conduct:
https://github.com/appwrite/appwrite/blob/master/CODE_OF_CONDUCT.md

Let me know if there is any feedback!

@eldadfux eldadfux pinned this issue Sep 13, 2019
@eldadfux eldadfux changed the title Adding Support for More OAuth Providers [HELP-WANTED] Adding Support for More OAuth Providers Sep 13, 2019
@eldadfux eldadfux added good first issue Good for newcomers hacktoberfest Issues that can win you some cool swags! labels Sep 20, 2019
@christyjacob4
Copy link
Member
christyjacob4 commented Sep 25, 2019 •
edited
Loading

Hey @eldadfux I would like to work on this. Please let me know if I can! Cheers!

@eldadfux
Copy link
Member

Hey @christyjacob4, sure you can. That will be amazing.

Before forking, please let us know here which providers you want to add first.

Also, make sure to read the contribution guide to follow our standards and best practices.

If anything is not clear please let me know. You can also join our Gitter community for live support and discussions:
https://gitter.im/appwrite/community

Happy #hacktobefest!

@christyjacob4
Copy link
Member

Hey @eldadfux Thanks for the prompt reply. I would like to start with Google and as I get familiar with the process would like to add more providers like Gitlab etc.. If you have any suggestions please let me know.

I'll approach you in case something is not clear.
Cheers!

@eldadfux
Copy link
Member

@christyjacob4 Google & Gitlab sounds great! I am available for any question!

@valishah
Copy link

Hey @eldadfux: Is it fine if I grab github oAuth and work?

@eldadfux
Copy link
Member

Hey @valishah, actually we already have implementations of Facebook, Github and Linkedin ready and working and @christyjacob4 is working on now on Google and Gitlab integrations.

But you can just tell me if there is any other provider you would like to work on and I will make a list to help future contributors know what integrations are still missing or in work.

eldadfux added a commit that referenced this issue Sep 30, 2019
@eldadfux
Merge pull request #37 from christyjacob4/master
fdb594e 
Fix issue #30 and #5
This was referenced Sep 30, 2019
Merged
Merged
@twoteesgh
Copy link

Hey! I'd like to add support for Twitter

@eldadfux
Copy link
Member

Hey @RhysEli,

Currently, @christyjacob4 has added Google & Gitlab adapters and is working on these adapters:

  • Bitbucket
  • Instagram
  • Microsoft
  • Twitter

@christyjacob4 maybe you could use some help with the new adapters?

@christyjacob4 Also note that according to these docs (https://developer.twitter.com/en/docs/basics/authentication/api-reference/token) Twitter has added support for OAuth 2, so this should be a lot less complicated than we thought.

@RhysEli If you would like, we could also use adapters for:
8000

@twoteesgh
Copy link
twoteesgh commented Oct 1, 2019 •
edited
Loading

@eldadfux Okay no problem. Shall I have a go with discord and twitch then?

@christyjacob4 christyjacob4 mentioned this issue Oct 1, 2019
Merged
@julian-castorena-eb
Copy link

Can I help with the Slack support?

@donofriov
Copy link

I'll add Twitch support.

@donofriov donofriov mentioned this issue Oct 2, 2019
Closed
This was referenced Oct 2, 2019
Merged
Closed
@donofriov donofriov mentioned this issue Oct 3, 2019
Closed
@bogdaaamn
Copy link
Contributor

@eldadfux @christyjacob4 I've got Slack. Just a quick fix and I'll make the PR

@christyjacob4
Copy link
Member

@bogdaaamn That's great .. Kindly post a screenshot in your PR so we can verify it.
You can follow this comment
#93 (comment)

This was referenced Jan 15, 2020
Merged
Merged
@eldadfux
Copy link 8000
Member
eldadfux commented Jan 17, 2020 •
edited
Loading

Updated @christyjacob4 list:

Done:

  • BitBucket
  • Facebook
  • Github
  • GitLab
  • Google
  • Microsoft
  • LinkedIn
  • Slack
  • DropBox
  • Amazon
  • VK
  • Discord
  • Twitch
  • Spotify

Ready for new PRs:

  • Twitter (OAuth2 not OAuth1)
  • Apple (Should be very similar to Auth2 - requires Apple developer account)
  • Yahoo
  • AOL
  • SalesForce
  • Bitly
  • Stripe
  • Shopify
  • PayPal
  • Mail.ru
  • Yandex
  • Baidu
  • Renren
  • Weibo

On Hold:

  • Instagram (Instagram has some technical difficulties since their API doesn't return an email ID, which we require)
  • Reddit (Reddit has some technical difficulties since their API doesn't return an email ID or a UUID or a full name, which we require)
  • SoundCloud (API doesn't return an email ID, which we require)

(at a future release of Appwrite we'll adjust the OAuth flow not to require an email, and then we'll go back to review the 'on hold' list)

@armino-dev armino-dev mentioned this issue Jan 17, 2020
Merged
This was referenced Jan 19, 2020
Merged
Merged
This was referenced Jan 20, 2020
Merged
Merged
@eldadfux
Copy link
Member

Just updated the the list with our latest Bitly and Salesforce adapters.
I thinks that if we have no technical issues with Twitter we should prioritise it.

@armino-dev
Copy link
Contributor

I have played yesterday with more providers, for example, battle.net and Vimeo. They do not return emails, unfortunately.
I think Shopify can't be used because their API is tight to a store. You need to make requests to an endpoint like {shop}.myshopify.com/admin/api
I tried Stripe but can't verify my account. Romania is not in their countries list, so I have abandoned it.
I'll play with Twitter API today and see if it can be fitted to our abstraction class

@eldadfux
Copy link
Member

@armino-dev thanks for the update.

As mentioned before on Discord and to keep everyone here at sync, Appwrite requires the email as a unique id for login and account recovery. We do have plans to add phone support and allow anonymous login in the future. Once we are there, I think we can revisit all the adapters that don't return an email.

We should also make future plans for custom settings, to allow adapters like Shopify and to allow more flexibility for adapters like PayPal, who support a production and a sandbox envs.

@armino-dev armino-dev mentioned this issue Jan 23, 2020
Closed
@eldadfux
Copy link
Member

Just finished working on the Apple adapter 🤘

@eldadfux eldadfux mentioned this issue Jun 13, 2020
Closed
39 tasks
@eldadfux
Copy link
Member

Closed in favor of #410

@eldadfux eldadfux unpinned this issue Jun 13, 2020
@Maatteogekko Maatteogekko mentioned this issue Jun 9, 2021
Closed
This was referenced Oct 12, 2021
Closed
Closed
@reyesmfabian reyesmfabian mentioned this issue Jan 22, 2022
Closed
2 tasks
@superseby2 superseby2 mentioned this issue Mar 3, 2022
Closed
2 tasks
@MaddPenguin MaddPenguin mentioned this issue Jun 11, 2022
Closed
@mbazs mbazs mentioned this issue Aug 2, 2022
Closed
2 tasks
@nbehler13 nbehler13 mentioned this issue Jan 25, 2023
Closed
2 tasks
christyjacob4 pushed a commit that referenced this issue Jan 27, 2023
@tusharxoxoxo
Merge pull request #5 from tusharxoxoxo/tusharxoxoxo-patch-5
4100a3a 
Update add-storage-adapter.md
@Mr-Malomz Mr-Malomz mentioned this issue Jul 30, 2023
Closed
2 tasks
@eauw eauw mentioned this issue Mar 25, 2024
Closed
2 tasks
@Re-Shard Re-Shard mentioned this issue Aug 11, 2024
Closed
2 tasks
@abhidev54 abhidev54 mentioned this issue Sep 22, 2024
Closed
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request good first issue Good for newcomers hacktoberfest Issues that can win you some cool swags! help wanted Extra attention is needed
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
0