Update delete project signature #10028
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
📝 WalkthroughWalkthroughThe visibility of the ✨ Finishing Touches
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
Documentation and Community
|
There was a problem hiding this comment.
Actionable comments posted: 0
🧹 Nitpick comments (1)
src/Appwrite/Platform/Workers/Deletes.php (1)
485-500: Doc-block is now out-of-sync with the widened signature; update it (and optionally mark the methodfinal).The visibility bump from
private→protectedis fine, but the accompanying doc-block still
- omits the new
$deviceForSitesand$certificatesparameters,- lists the parameters in the wrong order, and
- doesn’t reflect the new visibility (
@access protected).A quick patch keeps documentation accurate and avoids IDE / static-analysis drift:
@@ - * @param Database $dbForPlatform - * @param callable $getProjectDB - * @param Device $deviceForFiles - * @param Device $deviceForFunctions - * @param Device $deviceForBuilds - * @param Device $deviceForCache - * @param Document $document + * @param Database $dbForPlatform + * @param callable $getProjectDB + * @param Device $deviceForFiles + * @param Device $deviceForSites + * @param Device $deviceForFunctions + * @param Device $deviceForBuilds + * @param Device $deviceForCache + * @param CertificatesAdapter $certificates + * @param Document $document + * @access protected * @return void(Feel free to add
finalif subclasses should use but not override this heavy-duty routine.)
📜 Review details
Configuration used: .coderabbit.yaml
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (1)
src/Appwrite/Platform/Workers/Deletes.php(1 hunks)
⏰ Context from checks skipped due to timeout of 90000ms (6)
- GitHub Check: scan-pr / osv-scan
- GitHub Check: Setup & Build Appwrite Image
- GitHub Check: Check if utopia-php/database changed
- GitHub Check: Setup & Build Appwrite Image
- GitHub Check: Linter
- GitHub Check: scan
Security Scan Results for PRDocker Image Scan Results
Source Code Scan Results🎉 No vulnerabilities found! |
✨ Benchmark results
⚡ Benchmark Comparison
|
christyjacob4
approved these changes
Jun 18, 2025
…te-project-signature
… into update-delete-project-signature
…te-project-signature
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.