8000 Updated default permissions by eldadfux · Pull Request #1007 · appwrite/appwrite · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Updated default permissions #1007

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Mar 23, 2021
Merged

Conversation

eldadfux
Copy link
Member
@eldadfux eldadfux commented Mar 21, 2021

What does this PR do?

When no read or write permissions are passed when creating a document or a file the current user will be the one to obtain access (user:[USER_ID]).

When no permissions are being passed when updating a collection, document, or file the read & write attributes will inherit the previous values. When passing an empty array [], the permissions will be reset.

Test Plan

Existing E2E Tests

Related PRs and Issues

#1005
#979
#246
#983

Have you read the Contributing Guidelines on issues?

Yes.

Copy link
Contributor
@TorstenDittmann TorstenDittmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm 👍🏻

8000
Copy link
Member
@christyjacob4 christyjacob4 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks Good @eldadfux 👍

@eldadfux eldadfux marked this pull request as ready for review March 23, 2021 10:21
@eldadfux eldadfux merged commit 59e36b3 into dev Mar 23, 2021
@eldadfux eldadfux deleted the feat-set-default-permissions-to-user branch March 24, 2021 07:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants
0