-
Notifications
You must be signed in to change notification settings - Fork 4.6k
Revert "chore: update composer.json and composer.lock to include appwrite-lab…" #10086
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
📝 WalkthroughWalkthroughThe version constraint for the "utopia-php/queue" dependency in the "require" section of composer.json was changed from "0.12.*" to the fixed version "0.11.0". No other dependencies or configuration entries were altered, and there were no changes to exported or public entities. Possibly related PRs
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
Documentation and Community
|
…write-lab…" This reverts commit 99ccd64.
Security Scan Results for PRDocker Image Scan Results
Source Code Scan Results🎉 No vulnerabilities found! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
🧹 Nitpick comments (1)
composer.json (1)
70-70
: Downgrading & pinningutopia-php/queue
to a single patch version can introduce regressions & block security fixesThe revert locks the lib to
0.11.0
, losing all bug- and security-fix patches published on the 0.11 branch and any new APIs used since0.12.*
.
Please double-check that:
- No code added since the 0.12 bump relies on symbols introduced after 0.11.
- CI still passes with 0.11.0 across all supported PHP versions.
- You actually need an exact pin; preferring
"0.11.*"
(or even"^0.11"
) would allow future patch releases while keeping the major/minor series intact.Example loosening:
- "utopia-php/queue": "0.11.0", + "utopia-php/queue": "0.11.*",If the hard pin is required (e.g., for a known regression in 0.11.1+), please add an inline comment explaining the rationale so future maintainers don’t unintentionally upgrade it.
📜 Review details
Configuration used: .coderabbit.yaml
Review profile: CHILL
Plan: Pro
⛔ Files ignored due to path filters (1)
composer.lock
is excluded by!**/*.lock
📒 Files selected for processing (1)
composer.json
(1 hunks)
⏰ Context from checks skipped due to timeout of 90000ms (3)
- GitHub Check: Setup & Build Appwrite Image
- GitHub Check: Setup & Build Appwrite Image
- GitHub Check: scan
✨ Benchmark results
⚡ Benchmark Comparison
|
Reverts #10051