8000 Update nodejs 17.1.0 by ChiragAgg5k · Pull Request #10088 · appwrite/appwrite · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Update nodejs 17.1.0 #10088

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 8 commits into from
Jul 7, 2025
Merged

Update nodejs 17.1.0 #10088

merged 8 commits into from
Jul 7, 2025

Conversation

ChiragAgg5k
Copy link
Member

What does this PR do?

update nodejs, add changelog

Test Plan

Related PRs and Issues

Checklist

  • Have you read the Contributing Guidelines on issues?
  • If the PR includes a change to an API's metadata (desc, label, params, etc.), does it also include updated API specs and example docs?

@ChiragAgg5k ChiragAgg5k changed the base branch from main to 1.7.x July 2, 2025 05:32
Copy link
coderabbitai bot commented Jul 2, 2025

Important

Review skipped

Review was skipped due to path filters

⛔ Files ignored due to path filters (2)
  • composer.lock is excluded by !**/*.lock
  • docs/sdks/cli/CHANGELOG.md is excluded by !docs/sdks/**

CodeRabbit blocks several paths by default. You can override this behavior by explicitly including those paths in the path filters. For example, including **/dist/** will override the default block on the dist directory, by removing the pattern from both the lists.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

📝 Walkthrough

"""

Walkthrough

This change updates the version numbers of three SDKs in the Appwrite platforms configuration file. The CLI SDK version for the console platform is incremented from 8.1.0 to 8.1.1, and the Node.js SDK version for the server platform is updated from 17.0.0 to 17.1.0. Additionally, an unused import statement for the Hostname validator class was removed from the app/controllers/general.php file. The git commands for branch management in the SDK generation task were modified to use the "master" branch instead of "main". Only version strings, an import statement, and internal git command branch names are changed; no other properties, logic, or exported entities are affected.

Possibly related PRs

Suggested reviewers

  • christyjacob4
  • stnguyen90
    """

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Explain this complex logic.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai explain this code block.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and explain its main purpose.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR.
  • @coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

Copy link
github-actions bot commented Jul 2, 2025

Security Scan Results for PR

Docker Image Scan Results

Package Version Vulnerability 8000 Severity
binutils 2.42-r0 CVE-2025-0840 HIGH
libexpat 2.6.4-r0 CVE-2024-8176 HIGH
libxml2 2.12.7-r0 CVE-2024-56171 HIGH
libxml2 2.12.7-r0 CVE-2025-24928 HIGH
libxml2 2.12.7-r0 CVE-2025-27113 HIGH
libxml2 2.12.7-r0 CVE-2025-32414 HIGH
libxml2 2.12.7-r0 CVE-2025-32415 HIGH
pyc 3.12.9-r0 CVE-2024-12718 HIGH
pyc 3.12.9-r0 CVE-2025-4138 HIGH
pyc 3.12.9-r0 CVE-2025-4330 HIGH
pyc 3.12.9-r0 CVE-2025-4517 HIGH
python3 3.12.9-r0 CVE-2024-12718 HIGH
python3 3.12.9-r0 CVE-2025-4138 HIGH
python3 3.12.9-r0 CVE-2025-4330 HIGH
python3 3.12.9-r0 CVE-2025-4517 HIGH
python3-pyc 3.12.9-r0 CVE-2024-12718 HIGH
python3-pyc 3.12.9-r0 CVE-2025-4138 HIGH
python3-pyc 3.12.9-r0 CVE-2025-4330 HIGH
python3-pyc 3.12.9-r0 CVE-2025-4517 HIGH
python3-pycache-pyc0 3.12.9-r0 CVE-2024-12718 HIGH
python3-pycache-pyc0 3.12.9-r0 CVE-2025-4138 HIGH
python3-pycache-pyc0 3.12.9-r0 CVE-2025-4330 HIGH
python3-pycache-pyc0 3.12.9-r0 CVE-2025-4517 HIGH
sqlite-libs 3.45.3-r1 CVE-2025-29087 HIGH
xz 5.6.2-r0 CVE-2025-31115 HIGH
xz-libs 5.6.2-r0 CVE-2025-31115 HIGH
golang.org/x/crypto v0.31.0 CVE-2025-22869 HIGH

Source Code Scan Results

🎉 No vulnerabilities found!

@stnguyen90 stnguyen90 self-requested a review July 2, 2025 13:38
Copy link
@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

📜 Review details

Configuration used: .coderabbit.yaml
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 49a5e01 and 60158ae.

⛔ Files ignored due to path filters (5)
  • composer.lock is excluded by !**/*.lock
  • docs/examples/1.7.x/server-nodejs/examples/databases/upsert-document.md is excluded by !docs/examples/**
  • docs/examples/1.7.x/server-nodejs/examples/databases/upsert-documents.md is excluded by !docs/examples/**
  • docs/sdks/cli/CHANGELOG.md is excluded by !docs/sdks/**
  • docs/sdks/nodejs/CHANGELOG.md is excluded by !docs/sdks/**
📒 Files selected for processing (1)
  • app/config/platforms.php (2 hunks)
⏰ Context from checks skipped due to timeout of 90000ms (3)
  • GitHub Check: Setup & Build Appwrite Image
  • GitHub Check: Setup & Build Appwrite Image
  • GitHub Check: scan
🔇 Additional comments (2)
app/config/platforms.php (2)

220-220: CLI SDK version update not mentioned in PR title.

The PR title mentions only "Update nodejs 17.1.0" but this change also updates the CLI SDK version from 8.1.0 to 8.1.1. The PR description should clarify whether this CLI version update is intentional or if it was included by mistake.

Likely an incorrect or invalid review comment.


253-253: Node.js SDK version update aligns with PR objectives.

The version update from 17.0.0 to 17.1.0 matches the PR title and objectives. The change looks correct for a minor version bump.

Copy link
github-actions bot commented Jul 3, 2025

✨ Benchmark results

  • Requests per second: 883
  • Requests with 200 status code: 159,032
  • P99 latency: 0.213813267

⚡ Benchmark Comparison

Metric This PR Latest version
RPS 883 1,121
200 159,032 201,784
P99 0.213813267 0.16857335

Copy link
@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

📜 Review details

Configuration used: .coderabbit.yaml
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between dd9096f and 2cf7246.

⛔ Files ignored due to path filters (1)
  • docs/sdks/cli/CHANGELOG.md is excluded by !docs/sdks/**
📒 Files selected for processing (1)
  • src/Appwrite/Platform/Tasks/SDKs.php (1 hunks)
⏰ Context from checks skipped due to timeout of 90000ms (3)
  • GitHub Check: Setup & Build Appwrite Image
  • GitHub Check: Setup 8000 & Build Appwrite Image
  • GitHub Check: scan

Copy link
Member
@lohanidamodar lohanidamodar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.
Make sure to sync first and tests are fine after sync before merging

@lohanidamodar lohanidamodar merged commit edd7a4a into 1.7.x Jul 7, 2025
38 checks passed
@coderabbitai coderabbitai bot mentioned this pull request Jul 11, 2025
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants
0