-
Notifications
You must be signed in to change notification settings - Fork 4.6k
Update nodejs 17.1.0 #10088
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update nodejs 17.1.0 #10088
Conversation
Important Review skippedReview was skipped due to path filters ⛔ Files ignored due to path filters (2)
CodeRabbit blocks several paths by default. You can override this behavior by explicitly including those paths in the path filters. For example, including You can disable this status message by setting the 📝 Walkthrough""" WalkthroughThis change updates the version numbers of three SDKs in the Appwrite platforms configuration file. The CLI SDK version for the console platform is incremented from 8.1.0 to 8.1.1, and the Node.js SDK version for the server platform is updated from 17.0.0 to 17.1.0. Additionally, an unused import statement for the Possibly related PRs
Suggested reviewers
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
Documentation and Community
|
Security Scan Results for PRDocker Image Scan Results
Source Code Scan Results🎉 No vulnerabilities found! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 1
📜 Review details
Configuration used: .coderabbit.yaml
Review profile: CHILL
Plan: Pro
⛔ Files ignored due to path filters (5)
composer.lock
is excluded by!**/*.lock
docs/examples/1.7.x/server-nodejs/examples/databases/upsert-document.md
is excluded by!docs/examples/**
docs/examples/1.7.x/server-nodejs/examples/databases/upsert-documents.md
is excluded by!docs/examples/**
docs/sdks/cli/CHANGELOG.md
is excluded by!docs/sdks/**
docs/sdks/nodejs/CHANGELOG.md
is excluded by!docs/sdks/**
📒 Files selected for processing (1)
app/config/platforms.php
(2 hunks)
⏰ Context from checks skipped due to timeout of 90000ms (3)
- GitHub Check: Setup & Build Appwrite Image
- GitHub Check: Setup & Build Appwrite Image
- GitHub Check: scan
🔇 Additional comments (2)
app/config/platforms.php (2)
220-220
: CLI SDK version update not mentioned in PR title.The PR title mentions only "Update nodejs 17.1.0" but this change also updates the CLI SDK version from 8.1.0 to 8.1.1. The PR description should clarify whether this CLI version update is intentional or if it was included by mistake.
Likely an incorrect or invalid review comment.
253-253
: Node.js SDK version update aligns with PR objectives.The version update from 17.0.0 to 17.1.0 matches the PR title and objectives. The change looks correct for a minor version bump.
✨ Benchmark results
⚡ Benchmark Comparison
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 1
📜 Review details
Configuration used: .coderabbit.yaml
Review profile: CHILL
Plan: Pro
⛔ Files ignored due to path filters (1)
docs/sdks/cli/CHANGELOG.md
is excluded by!docs/sdks/**
📒 Files selected for processing (1)
src/Appwrite/Platform/Tasks/SDKs.php
(1 hunks)
⏰ Context from checks skipped due to timeout of 90000ms (3)
- GitHub Check: Setup & Build Appwrite Image
- GitHub Check: Setup 8000 & Build Appwrite Image
- GitHub Check: scan
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good.
Make sure to sync first and tests are fine after sync before merging
What does this PR do?
update nodejs, add changelog
Test Plan
Related PRs and Issues
Checklist