8000 fix: origin validation for web extensions by ChiragAgg5k · Pull Request #10107 · appwrite/appwrite · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

fix: origin validation for web extensions #10107

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Jul 6, 2025
Merged

fix: origin validation for web extensions #10107

merged 4 commits into from
Jul 6, 2025

Conversation

ChiragAgg5k
Copy link
Member

What does this PR do?

To fix the error:

Invalid Origin. Register your new client (jjkacomhkeejdlpddhjpfeokhgfceefd) as a new platform on your project console dashboard.

Test Plan

Related PRs and Issues

Checklist

  • Have you read the Contributing Guidelines on issues?
  • If the PR includes a change to an API's metadata (desc, label, params, etc.), does it also include updated API specs and example docs?

@coderabbitai coderabbitai
Copy link
coderabbitai bot commented Jul 5, 2025 •
edited
Loading
📝 Walkthrough

Walkthrough

The changes add four new scheme constants to the Platform class for Chrome, Firefox, Safari, and Edge browser extensions, along with corresponding user-friendly platform names in the internal mapping. In the Origin validator, the isValid method is updated to recognize these new extension schemes in addition to HTTP and HTTPS when validating the origin's scheme. The method now checks if the origin’s scheme is included in this expanded set before validating the hostname. The unit tests for the Origin validator are extended to assert that origins with these new extension schemes are invalid and produce specific error messages prompting registration of the client as a new Web platform. No other method signatures or control flow are modified.

Possibly related PRs

  • feat: exp scheme #9650: Adds new browser extension schemes to the Platform class and updates the Origin validator to recognize these schemes, similar to this PR but focusing on different scheme sets.

Suggested reviewers

  • christyjacob4
  • stnguyen90
📜 Recent review details

Configuration used: .coderabbit.yaml
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between ca52771 and 5fffae3.

📒 Files selected for processing (3)
  • src/Appwrite/Network/Platform.php (2 hunks)
  • src/Appwrite/Network/Validator/Origin.php (1 hunks)
  • tests/unit/Network/Validators/OriginTest.php (1 hunks)
🚧 Files skipped from review as they are similar to previous changes (2)
  • src/Appwrite/Network/Validator/Origin.php
  • src/Appwrite/Network/Platform.php
🧰 Additional context used
🧬 Code Graph Analysis (1)
tests/unit/Network/Validators/OriginTest.php (2)
src/Appwrite/Network/Validator/Origin.php (2)
  • isValid (33-63)
  • getDescription (69-80)
src/Appwrite/Network/Validator/Redirect.php (1)
  • getDescription (13-24)
⏰ Context from checks skipped due to timeout of 90000ms (2)
  • GitHub Check: Setup & Build Appwrite Image
  • GitHub Check: scan
🔇 Additional comments (1)
tests/unit/Network/Validators/OriginTest.php (1)

98-109: Approved: Browser extension platform name mappings match tests

Verified that Platform::getNameByScheme() returns the expected names for all extension schemes used in tests/unit/Network/Validators/OriginTest.php (lines 98–109). The error messages for Chrome, Firefox, Safari, and Edge extensions correctly read:

  • Web (Chrome Extension)
  • Web (Firefox Extension)
  • Web (Safari Extension)
  • Web (Edge Extension)

No changes required.

✨ Finishing Touches
  • 📝 Generate Docstrings

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Explain this complex logic.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai explain this code block.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and explain its main purpose.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR.
  • @coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

coderabbitai[bot]
coderabbitai bot reviewed Jul 5, 2025
View reviewed changes
Copy link
@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

📜 Review details

Configuration used: .coderabbit.yaml
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 1cf9963 and 0fb55f6.

📒 Files selected for processing (2)
  • src/Appwrite/Network/Platform.php (2 hunks)
  • src/Appwrite/Network/Validator/Origin.php (1 hunks)
🧰 Additional context used
🧬 Code Graph Analysis (1)
src/Appwrite/Network/Validator/Origin.php (1)
src/Appwrite/Network/Platform.php (1)
  • Platform (5-159)
⏰ Context from checks skipped due to timeout of 90000ms (4)
  • GitHub Check: Setup & Build Appwrite Image
  • GitHub Check: Setup & Build Appwrite Image
  • GitHub Check: Linter
  • GitHub Check: scan
🔇 Additional comments (2)
src/Appwrite/Network/Platform.php (1)

52-55: User-friendly names follow good naming conventions.

The platform names are descriptive and consistent with the existing naming pattern in the $names array.

src/Appwrite/Network/Validator/Origin.php (1)

45-53: Excellent approach to centralize web platform scheme validation.

The refactoring to use a $webPlatforms array is a good design choice that:

  1. Centralizes the list of schemes requiring hostname validation
  2. Makes the code more maintainable and readable
  3. Properly extends validation to browser extension schemes
  4. Fixes the core issue described in the PR objectives

This change should resolve the "Invalid Origin" error for web extensions by ensuring they go through the same hostname validation as HTTP/HTTPS origins.

@github-actions GitHub Actions
Copy link
github-actions bot commented Jul 5, 2025 •
edited
Loading

Security Scan Results for PR

Docker Image Scan Results

Package Version Vulnerability Severity
binutils 2.42-r0 CVE-2025-0840 HIGH
libexpat 2.6.4-r0 CVE-2024-8176 HIGH
libxml2 2.12.7-r0 CVE-2024-56171 HIGH
libxml2 2.12.7-r0 CVE-2025-24928 HIGH
libxml2 2.12.7-r0 CVE-2025-27113 HIGH
libxml2 2.12.7-r0 CVE-2025-32414 HIGH
libxml2 2.12.7-r0 CVE-2025-32415 HIGH
pyc 3.12.9-r0 CVE-2024-12718 HIGH
pyc 3.12.9-r0 CVE-2025-4138 HIGH
pyc 3.12.9-r0 CVE-2025-4330 HIGH
pyc 3.12.9-r0 CVE-2025-4517 HIGH
python3 3.12.9-r0 CVE-2024-12718 HIGH
python3 3.12.9-r0 CVE-2025-4138 HIGH
python3 3.12.9-r0 CVE-2025-4330 HIGH
python3 3.12.9-r0 CVE-2025-4517 HIGH
python3-pyc 3.12.9-r0 CVE-2024-12718 HIGH
python3-pyc 3.12.9-r0 CVE-2025-4138 HIGH
python3-pyc 3.12.9-r0 CVE-2025-4330 HIGH
python3-pyc 3.12.9-r0 CVE-2025-4517 HIGH
python3-pycache-pyc0 3.12.9-r0 CVE-2024-12718 HIGH
python3-pycache-pyc0 3.12.9-r0 CVE-2025-4138 HIGH
python3-pycache-pyc0 3.12.9-r0 CVE-2025-4330 HIGH
python3-pycache-pyc0 3.12.9-r0 CVE-2025-4517 HIGH
sqlite-libs 3.45.3-r1 CVE-2025-29087 HIGH
xz 5.6.2-r0 CVE-2025-31115 HIGH
xz-libs 5.6.2-r0 CVE-2025-31115 HIGH
golang.org/x/crypto v0.31.0 CVE-2025-22869 HIGH

Source Code Scan Results

🎉 No vulnerabilities found!

@github-actions GitHub Actions
Copy link
github-actions bot commented Jul 5, 2025 •
edited
Loading

✨ Benchmark results

  • Requests per second: 885
  • Requests with 200 status code: 159,340
  • P99 latency: 0.214923948

⚡ Benchmark Comparison

Metric This PR Latest version
RPS 885 1,118
200 159,340 201,358
P99 0.214923948 0.169468522

@ChiragAgg5k ChiragAgg5k force-pushed the fix-origin-validation-extensions branch from ca52771 to 9dcb806 Compare July 5, 2025 12:00
@stnguyen90 stnguyen90 merged commit 543b872 into 1.7.x Jul 6, 2025
38 checks passed
This was referenced Jul 9, 2025
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@coderabbitai coderabbitai[bot] coderabbitai[bot] left review comments

@stnguyen90 stnguyen90 stnguyen90 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ChiragAgg5k @stnguyen90
0