Implement Utopia Orchestration library into Appwrite #1420
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TorstenDittmann
requested changes
Aug 3, 2021
TorstenDittmann
approved these changes
Aug 3, 2021
kodumbeats
suggested changes
Aug 9, 2021
kodumbeats
suggested changes
Aug 12, 2021
This reverts commit bd537e6.
kodumbeats
suggested changes
Aug 13, 2021
+ Added documentation for environment variables + Added changelog + Changed how we handle a error while removing a container that may or may not exist during execution
…IOnic/appwrite into orchestration-api-test
eldadfux
approved these changes
Aug 16, 2021
kodumbeats
approved these changes
Aug 17, 2021
There was a problem hiding this comment.
Looks good @PineappleIOnic , but let's make sure it gets merged to the right branch? Is master the target?
PineappleIOnic wants to merge 23 commits into
appwrite:masterfromPineappleIOnic:orchestration-api-test
0da64d4 to
38e1624
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
This PR will replace our current docker CLI implementation with the Orchestration Library from Utopia
Test Plan
I didn't change the tests and used them as a way to make sure the refactor was correctly working
Have you read the Contributing Guidelines on issues?
Yes, I have