Feat locale refactor #1422
Merged
Feat locale refactor #1422
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eldadfux
reviewed
Jul 23, 2021
68b4085 to
b911673
Compare
eldadfux
requested changes
Jul 24, 2021
src/Appwrite/Template/Template.php
Outdated
| * @return string | ||
| * | ||
| */ | ||
| public function getHtml(): string |
There was a problem hiding this comment.
Again as the above comment, not sure why we need dedicated setters as getters, seems like there is no much code repetitiveness this is saving us. Probably better avoid coupling with HTML, this template can be used with any view format.
| @@ -42,7 +40,8 @@ | |||
|
|
|||
| if ($record) { | |||
| $output['countryCode'] = $record['country']['iso_code']; | |||
| $output['country'] = (isset($countries[$record['country']['iso_code']])) ? $countries[$record['country']['iso_code']] : $locale->getText('locale.country.unknown'); | |||
| $output['country'] = $locale->getText('countries.'.strtolower($record['country']['iso_code']), $locale->getText('locale.country.unknown')); | |||
There was a problem hiding this comment.
Why did we gave up the isset method check? We better be safe than sorry :)
There was a problem hiding this comment.
This has multiple instances across the diff, I'll avoid commenting on each one :)
There was a problem hiding this comment.
$locale->getText() takes a default param. So I thought we can use that instead 👍
Remove CTA template and move logic to mails worker
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Template()inappwrite/app/controllers/api/account.php
Line 1723 in 16b3c5c
Test Plan
Use Existing tests
Related PRs and Issues
NA
Have you read the Contributing Guidelines on issues?
YES