Fix : translation french "emails.recovery.body" #4783
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
christyjacob4
approved these changes
Nov 25, 2022
|
@pomarec thanks a lot for the contribution! Can you please resolve the conflicts in the changelog? Could you also give another look at the French translations to ensure everything looks good ? |
923133c to
810e43f
Compare
Wrong reference to project variable
810e43f to
31089b7
Compare
|
I found another error, emails.certificate.body contained auto translated var names FYI : emails.invitation.subject contains "%s" two times, not named vars. Its the same in every language. |
stnguyen90
approved these changes
Dec 21, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Wrong reference to project variable
What does this PR do?
Fixes translation french "emails.recovery.body"
Test Plan
Send an email recovery in french
Related PRs and Issues
#4782
Have you added your change to the Changelog?
yes
Have you read the Contributing Guidelines on issues?
yes