8000 Fix 4982 email session expire string formattz by munyoudoum · Pull Request #4985 · appwrite/appwrite · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Fix 4982 email session expire string formattz #4985

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Feb 24, 2023
Merged

Fix 4982 email session expire string formattz #4985

merged 4 commits into from
Feb 24, 2023

Conversation

munyoudoum
Copy link
Contributor
@munyoudoum munyoudoum commented Jan 11, 2023 •
edited
Loading

What does this PR do?

  • fix expire string format to formatTz in create account session

image

Test Plan

  • added 2 assertions

Related PRs and Issues

#4982

Have you added your change to the Changelog?

(The CHANGES.md file tracks all the changes that make it to the main branch. Add your change to this file in the following format)

  • One line description of your PR [#pr_number](Link to your PR)

Have you read the Contributing Guidelines on issues?

Yes

@stnguyen90 stnguyen90 linked an issue Jan 12, 2023 that may be closed by this pull request
🐛 Bug Report: expire is not formatted the same as other datetimes #4982
Closed
7 tasks
stnguyen90
stnguyen90 requested changes Jan 12, 2023
View reviewed changes
Copy link
Contributor
@stnguyen90 stnguyen90 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great PR! 🤯 Would you please also check some other methods:

  1. Create Magic URL session (confirmation)
  2. Create Phone Session (confirmation)
  3. Create Anonymous Session
  4. Get Session
  5. Update OAuth Session (Refresh Tokens)

@munyoudoum
Copy link
Contributor Author

Not sure when I'll be available to work on this.
If possible, you can merge it first and let others contribute the remaining methods because it also fixed the reported bug

@stnguyen90 stnguyen90 self-requested a review January 28, 2023 00:20
@munyoudoum munyoudoum force-pushed the fix-4982-email-session-expire-string-formattz branch from 2c4697f to 63b54ea Compare January 29, 2023 17:33
@munyoudoum munyoudoum marked this pull request as draft January 29, 2023 17:44
@munyoudoum munyoudoum marked this pull request as ready for review January 29, 2023 17:44
@stnguyen90 stnguyen90 removed a link to an issue Feb 1, 2023
🐛 Bug Report: expire is not formatted the same as other datetimes #4982
Closed
7 tasks
@TorstenDittmann TorstenDittmann merged commit d043a74 into appwrite:master Feb 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stnguyen90 stnguyen90 stnguyen90 approved these changes

@TorstenDittmann TorstenDittmann TorstenDittmann approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@munyoudoum @stnguyen90 @TorstenDittmann
0