8000 Fix: spanish translations (emails) by DH-555 · Pull Request #5290 · appwrite/appwrite · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Fix: spanish translations (emails) #5290

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Oct 13, 2023
Merged

Fix: spanish translations (emails) #5290

merged 3 commits into from
Oct 13, 2023

Conversation

DH-555
Copy link
Member
@DH-555 DH-555 commented Mar 28, 2023 •
edited
Loading

What does this PR do?

Some translations to spanish had some misspellings and redaction issues. Fixed that.

Test Plan

(Not tested, but obviously works, no real code was modified)

Related PRs and Issues

Checklist

  • Have you read the Contributing Guidelines on issues?
  • If the PR includes a change to an API's metadata (desc, label, params, etc.), does it also include updated API specs and example docs?

@DH-555
Corrected spanish translations (emails)
536bcf2 
Some translations to spanish had some misspellings and redaction issues. Fixed that.
@DH-555 DH-555 changed the title Corrected spanish translations (emails) Fix: spanish translations (emails) Mar 28, 2023
@DH-555
Copy link
Member Author
DH-555 commented Mar 29, 2023 •
edited
Loading

Almost all companies only use the app or company name in the sender email without any additional text, since if it has before the app name "The team of", email providers may cut off the following text (who is the most important part: your app's name).

For example, WordPress shows "WordPress" instead of "The WordPress team".

In English, that's not a big issue since it just has before "the" and if is cut off, what is not going to be seen is the word "team". In Spanish, it's translated into what's equivalent to "The team of [yourAppName]"

Should I make them appear in the sender's name just the app name, like 99% of the companies?

@DH-555
Copy link
Member Author
DH-555 commented Jul 4, 2023

Is this being reviewed?

Meldiron
Meldiron reviewed Jul 17, 2023
View reviewed changes
@DH-555
Update es.json
3a42dca 
Fixed suggested changes by Matej
@DH-555 DH-555 requested a review from Meldiron July 19, 2023 20:51
gewenyu99
gewenyu99 approved these changes Jul 24, 2023
View reviewed changes
Copy link
Contributor
@gewenyu99 gewenyu99 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

According to @heyCarla, the spanish checks out. Please address Matej's comments and request another review from him.

LGTM on my end

@TorstenDittmann TorstenDittmann merged commit ce0024d into appwrite:main Oct 13, 2023
@github-actions github-actions bot mentioned this pull request Nov 1, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@TorstenDittmann TorstenDittmann TorstenDittmann approved these changes

@Meldiron Meldiron Meldiron approved these changes

@gewenyu99 gewenyu99 gewenyu99 approved these changes

@christyjacob4 christyjacob4 Awaiting requested review from christyjacob4

Assignees
No one assigned
Labels
None yet
Projects
No open projects
1.4 release
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@DH-555 @TorstenDittmann @Meldiron @gewenyu99
0