10000 fix: throw correct exception when project ID already exists by christyjacob4 · Pull Request #5460 · appwrite/appwrite · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

fix: throw correct exception when project ID already exists #5460

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
May 19, 2023
Merged

fix: throw correct exception when project ID already exists #5460

merged 4 commits into from
May 19, 2023

Conversation

christyjacob4
Copy link
Member

What does this PR do?

Throw the correct exception when creating a project with a requested ID already exists

Test Plan

(Write your test plan here. If you changed any code, please provide us with clear instructions on how you verified your changes work. Screenshots may also be helpful.)

Related PRs and Issues

  • (Related PR or issue)

Checklist

  • Have you read the Contributing Guidelines on issues?
  • If the PR includes a change to an API's metadata (desc, label, params, etc.), does it also include updated API specs and example docs?

stnguyen90
stnguyen90 requested changes Apr 29, 2023
View reviewed changes
christyjacob4
christyjacob4 commented Apr 29, 2023
View reviewed changes
christyjacob4
christyjacob4 commented Apr 29, 2023
View reviewed changes
christyjacob4
christyjacob4 commented Apr 29, 2023
View reviewed changes
@christyjacob4 christyjacob4 changed the title fix: throw correct exception when project custom ID already exists fix: throw correct exception when project ID already exists May 1, 2023
@christyjacob4 christyjacob4 requested a review from stnguyen90 May 5, 2023 12:47
stnguyen90
stnguyen90 approved these changes May 8, 2023
View reviewed changes
Copy link
Contributor
@stnguyen90 stnguyen90 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

This is what the error looks like now:

image

@christyjacob4 christyjacob4 merged commit d630d87 into master May 19, 2023
@TorstenDittmann TorstenDittmann deleted the fix-create-project-error branch September 10, 2023 16:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stnguyen90 stnguyen90 stnguyen90 approved these changes

@TorstenDittmann TorstenDittmann TorstenDittmann approved these changes

@Meldiron Meldiron Awaiting requested review from Meldiron

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@christyjacob4 @stnguyen90 @TorstenDittmann
0