8000 Docs: Create document and unknown attribute error messages. by gewenyu99 · Pull Request #5427 · appwrite/appwrite · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Docs: Create document and unknown attribute error messages. #5427

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Dec 13, 2024
Merged

Docs: Create document and unknown attribute error messages. #5427

merged 1 commit into from
Dec 13, 2024

Conversation

gewenyu99
Copy link
Contributor

…own attribute.

What does this PR do?

  • Create document description doesn't warn users to create an attribute first
  • Improve the error message with some suggested next steps.

Test Plan

(Write your test plan here. If you changed any code, please provide us with clear instructions on how you verified your changes work. Screenshots may also be helpful.)

Related PRs and Issues

Checklist

  • Have you read the Contributing Guidelines on issues?
  • If the PR includes a change to an API's metadata (desc, label, params, etc.), does it also include updated API specs and example docs?

@gewenyu99 gewenyu99 requested a review from stnguyen90 April 24, 2023 22:58
stnguyen90
stnguyen90 requested changes May 4, 2023
View reviewed changes
app/controllers/api/databases.php
@@ -2399,7 +2399,7 @@ function updateAttribute(
$attributeIndex = \array_search($attribute, array_column($oldAttributes, 'key'));

if ($attributeIndex === false) {
throw new Exception(Exception::ATTRIBUTE_UNKNOWN, 'Unknown attribute: ' . $attribute);
throw new Exception(Exception::ATTRIBUTE_UNKNOWN, 'Unknown attribute: ' . $attribute . '. Verify the attribute name or create the attribute.");
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

mismatch quote

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

GDI

@gewenyu99 gewenyu99 mentioned this pull request Dec 12, 2024
Merged
2 tasks
@christyjacob4 christyjacob4 merged commit bb31431 into main Dec 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stnguyen90 stnguyen90 stnguyen90 requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@gewenyu99 @stnguyen90 @christyjacob4
0