Update the Update Account Status API to clear the cookie #5561
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
After a user updates their status, their session no longer works however, the cookie may still exist in their browser, preventing other API calls from completing successfully.
lohanidamodar
approved these changes
May 22, 2023
|
How does having an invalid cookie interfere with other calls? |
Since the cookie is still there, API calls result in "User is blocked error" which can prevent progressing in the app/Console. For example, this shows deleting the account and then refreshing the page/navigating to the console again: delete-refresh.movAnd here's another with trying to create a new (different) account after deleting: Screen.Recording.2023-05-22.at.7.42.28.AM.mov |
|
Can we also change the error message? "You can unblock the user from the console" part is not relevant to the person receiving the error. |
Remove the "You can unblock the user from the Appwrite console." part as it is not relevant for the person receiving the error.
eldadfux
approved these changes
May 22, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
After a user updates their status, their session no longer works however, the cookie may still exist in their browser, preventing other API calls from completing successfully.
Test Plan
E2E test updated
Related PRs and Issues
Checklist