8000 Add a new labels attribute to the Users collection by stnguyen90 · Pull Request #5587 · appwrite/appwrite · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Add a new labels attribute to the Users collection #5587

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 6 commits into from
Jul 18, 2023
Merged

Add a new labels attribute to the Users collection #5587

merged 6 commits into from
Jul 18, 2023

Conversation

stnguyen90
Copy link
Contributor
@stnguyen90 stnguyen90 commented May 27, 2023 •
edited
Loading

What does this PR do?

This labels attribute can be used apply labels to users. These labels can eventually be used:

  • with permissions to grant access
  • to filter users in the Users collection

Test Plan

Automated

Related PRs and Issues

Depends on:

Blocks:

Checklist

  • Have you read the Contributing Guidelines on issues?
  • If the PR includes a change to an API's metadata (desc, label, params, etc.), does it also include updated API specs and example docs?

@stnguyen90 stnguyen90 changed the base branch from master to 1.4.x May 27, 2023 01:45
@stnguyen90 stnguyen90 marked this pull request as draft May 27, 2023 01:45
eldadfux
eldadfux reviewed May 27, 2023
View reviewed changes
Copy link
Member
@eldadfux eldadfux left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@stnguyen90 looks great, left a few suggestions.

@stnguyen90 stnguyen90 requested a review from eldadfux May 31, 2023 14:22
@stnguyen90 stnguyen90 mentioned this pull request Jun 2, 2023
Merged
@stnguyen90
Add a new labels attribute to the Users collection
85a40bf 
This labels attribute can be used apply labels to users. These labels
can eventually be used:

* with permissions to grant access
* to filter users in the Users collection
@stnguyen90 stnguyen90 force-pushed the feat-user-labels branch 2 times, most recently from 42777f4 to b98e0f3 Compare June 5, 2023 21:24
@stnguyen90 stnguyen90 marked this pull request as ready for review June 6, 2023 20:40
TorstenDittmann
TorstenDittmann reviewed Jun 9, 2023
View reviewed changes
eldadfux
eldadfux requested changes Jul 5, 2023
View reviewed changes
@stnguyen90 stnguyen90 mentioned this pull request Jul 5, 2023
Closed
2 tasks
@stnguyen90
Update user's search attribute using database filter
8258d70 
Using a database filter is the cleanest approach because it ensures
the logic is applied whenever the user is updated regardless of
whichever endpoint was used.
@stnguyen90 stnguyen90 requested a review from eldadfux July 5, 2023 19:18
@stnguyen90 stnguyen90 mentioned this pull request Jul 5, 2023
Merged
@stnguyen90 stnguyen90 added this to the 1.4.0 milestone Jul 17, 2023
@TorstenDittmann TorstenDittmann merged commit 74308b4 into 1.4.x Jul 18, 2023
@TorstenDittmann TorstenDittmann deleted the feat-user-labels branch July 18, 2023 12:59
@github-actions github-actions bot mentioned this pull request Aug 1, 2023
Closed
@stnguyen90 stnguyen90 mentioned this pull request Aug 10, 2023
Merged
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@eldadfux eldadfux eldadfux approved these changes

@TorstenDittmann TorstenDittmann TorstenDittmann approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
1.4.0
Development

Successfully merging this pull request may close these issues.
3 participants
@stnguyen90 @eldadfux @TorstenDittmann
0