8000 Fix the routing for the default OAuth2 pages by stnguyen90 · Pull Request #5640 · appwrite/appwrite · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Fix the routing for the default OAuth2 pages #5640

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 3, 2023
Merged

Fix the routing for the default OAuth2 pages #5640

merged 1 commit into from
Jun 3, 2023

Conversation

stnguyen90
Copy link
Contributor

What does this PR do?

Without this, you would get a 404 trying to browse to the default OAuth2 pages.

Test Plan

Added a new e2e test

Related PRs and Issues

Checklist

  • Have you read the Contributing Guidelines on issues?
  • If the PR includes a change to an API's metadata (desc, label, params, etc.), does it also include updated API specs and example docs?

@stnguyen90 stnguyen90 marked this pull request as ready for review June 2, 2023 21:35
@stnguyen90 stnguyen90 added this to the 1.3.7 milestone Jun 2, 2023
@christyjacob4 christyjacob4 merged commit 73f410c into master Jun 3, 2023
@christyjacob4 christyjacob4 deleted the fix-oauth-routes branch June 3, 2023 07:21
@stnguyen90 stnguyen90 mentioned this pull request Jul 22, 2023
Merged
This was referenced Jul 25, 2023
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@christyjacob4 christyjacob4 christyjacob4 approved these changes

@TorstenDittmann TorstenDittmann Awaiting requested review from TorstenDittmann

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
1.3.7
Development

Successfully merging this pull request may close these issues.
2 participants
@stnguyen90 @christyjacob4
0