8000 Update document missing params error message by abnegate · Pull Request #5671 · appwrite/appwrite · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Update document missing params error message #5671

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jun 12, 2023
Merged

Update document missing params error message #5671

merged 2 commits into from
Jun 12, 2023

Conversation

abnegate
Copy link
Member
@abnegate abnegate commented Jun 7, 2023

What does this PR do?

Add new error message to differentiate between missing data and missing data and permissions between document create and document update.

Test Plan

N/A

Related PRs and Issues

N/A

Checklist

  • Have you read the Contributing Guidelines on issues?
  • If the PR includes a change to an API's metadata (desc, label, params, etc.), does it also include updated API specs and example docs?

gewenyu99
gewenyu99 suggested changes Jun 8, 2023
View reviewed changes
Copy link
Contributor
@gewenyu99 gewenyu99 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Updating this to follow a [What went wrong] | [What we think happened] | [Next steps to try] format

@abnegate abnegate requested a review from gewenyu99 June 9, 2023 01:09
gewenyu99
gewenyu99 approved these changes Jun 9, 2023
View reviewed changes
Copy link
Contributor
@gewenyu99 gewenyu99 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM <3

@abnegate abnegate changed the base branch from master to 1.4.x June 12, 2023 02:00
@abnegate abnegate changed the base branch from 1.4.x to master June 12, 2023 02:00
@abnegate abnegate merged commit fd7a2cb into master Jun 12, 2023
@stnguyen90 stnguyen90 mentioned this pull request Jul 22, 2023
Merged
@gewenyu99 gewenyu99 mentioned this pull request Jul 25, 2023
Closed
2 tasks
This was referenced Jul 25, 2023
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
@TorstenDittmann TorstenDittmann deleted the feat-update-error-message branch September 10, 2023 16:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gewenyu99 gewenyu99 gewenyu99 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@abnegate @gewenyu99
0