Fix system performance #5620

stnguyen90 · 2023-06-01T00:11:44Z

What does this PR do?

Prevent triggering a function off of a function
Don't clear cache on startup
Update console to include new fixes from fix: remove default order console#458
Add Check for recursive function execution in the functions worker.

Test Plan

Tested adding a functions.* event

Related PRs and Issues

None

Checklist

Have you read the Contributing Guidelines on issues?
If the PR includes a change to an API's metadata (desc, label, params, etc.), does it also include updated API specs and example docs?

stnguyen90 · 2023-06-01T00:14:22Z

src/Appwrite/Event/Validator/Event.php

+
+        if ($type == 'functions') {
+            $this->message = 'Triggering a function on a function event is not allowed.';
+            return false;


This is one approach.

Alternatively, we can remove the event from:

appwrite/app/config/events.php

Lines 195 to 236 in 0765aac

'functions' => [

'$model' => Response::MODEL_FUNCTION,

'$resource' => true,

'$description' => 'This event triggers on any functions event.',

'deployments' => [

'$model' => Response::MODEL_DEPLOYMENT,

'$resource' => true,

'$description' => 'This event triggers on any deployments event.',

'create' => [

'$description' => 'This event triggers when a deployment is created.',

],

'delete' => [

'$description' => 'This event triggers when a deployment is deleted.'

],

'update' => [

'$description' => 'This event triggers when a deployment is updated.'

],

],

'executions' => [

'$model' => Response::MODEL_EXECUTION,

'$resource' => true,

'$description' => 'This event triggers on any executions event.',

'create' => [

'$description' => 'This event triggers when an execution is created.',

],

'delete' => [

'$description' => 'This event triggers when an execution is deleted.'

],

'update' => [

'$description' => 'This event triggers when an execution is updated.'

],

],

'create' => [

'$description' => 'This event triggers when a function is created.'

],

'delete' => [

'$description' => 'This event triggers when a function is deleted.',

],

'update' => [

'$description' => 'This event triggers when a function is updated.',

]

]

If we remove the functions events from the events.php file we will also disable it for webhooks and realtime.

stnguyen90 added 2 commits May 31, 2023 14:06

Don't clear cache on startup

02cd872

Prevent triggering a function off of a function

2ee7a3a

stnguyen90 requested review from eldadfux and christyjacob4 June 1, 2023 00:11

stnguyen90 changed the base branch from master to feat-db-pools-master June 1, 2023 00:12

stnguyen90 commented Jun 1, 2023

View reviewed changes

christyjacob4 added 2 commits June 2, 2023 17:19

feat: remove unused orderBy, skip executing recursive functions

23e6c1a

fix: update console

fac4b6f

TorstenDittmann approved these changes Jun 2, 2023

View reviewed changes

christyjacob4 approved these changes Jun 2, 2023

View reviewed changes

chore: linter

36f1791

christyjacob4 merged commit b68f601 into feat-db-pools-master Jun 2, 2023

christyjacob4 deleted the fix-system-performance branch June 2, 2023 12:33

stnguyen90 mentioned this pull request Jul 22, 2023

Create GH workflow to generate github metrics appwrite/.github#23

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Fix system performance #5620

Fix system performance #5620

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

	'functions' => [
	'$model' => Response::MODEL_FUNCTION,
	'$resource' => true,
	'$description' => 'This event triggers on any functions event.',
	'deployments' => [
	'$model' => Response::MODEL_DEPLOYMENT,
	'$resource' => true,
	'$description' => 'This event triggers on any deployments event.',
	'create' => [
	'$description' => 'This event triggers when a deployment is created.',
	],
	'delete' => [
	'$description' => 'This event triggers when a deployment is deleted.'
	],
	'update' => [
	'$description' => 'This event triggers when a deployment is updated.'
	],
	],
	'executions' => [
	'$model' => Response::MODEL_EXECUTION,
	'$resource' => true,
	'$description' => 'This event triggers on any executions event.',
	'create' => [
	'$description' => 'This event triggers when an execution is created.',
	],
	'delete' => [
	'$description' => 'This event triggers when an execution is deleted.'
	],
	'update' => [
	'$description' => 'This event triggers when an execution is updated.'
	],
	],
	'create' => [
	'$description' => 'This event triggers when a function is created.'
	],
	'delete' => [
	'$description' => 'This event triggers when a function is deleted.',
	],
	'update' => [
	'$description' => 'This event triggers when a function is updated.',
	]
	]

Fix system performance #5620

Fix system performance #5620

Uh oh!

Conversation

Uh oh!

What does this PR do?

Test Plan

Related PRs and Issues

Checklist

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!