Feat database upgrade #5710
Merged
Feat database upgrade #5710
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
� Conflicts: � composer.json � composer.lock
fogelito
approved these changes
Jun 21, 2023
| @@ -487,6 +487,11 @@ | |||
| 'description' => 'Index with the requested ID already exists.', | |||
| 'code' => 409, | |||
| ], | |||
| Exception::INDEX_INVALID => [ | |||
| 'name' => Exception::INDEX_INVALID, | |||
| 'description' => 'Index invalid.', | |||
There was a problem hiding this comment.
Could we have a more descriptive error message here ?
There was a problem hiding this comment.
This is only really a placeholder - we pass through the actual error from the validator when we construct the exception, this would only be used in cases we don't do that
christyjacob4
approved these changes
Jun 21, 2023
This was referenced Jul 25, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Merge together:
userInternalIdfrom auditsTest Plan
Related PRs and Issues
#4575 -> utopia-php/database#268 -> utopia-php/database#218
#5439 -> utopia-php/database#264
utopia-php/database#271
utopia-php/audit#50
Checklist