8000 Fix np TLD validation by stnguyen90 · Pull Request #5847 · appwrite/appwrite · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Fix np TLD validation #5847

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jul 20, 2023
Merged

Fix np TLD validation #5847

merged 2 commits into from
Jul 20, 2023

Conversation

stnguyen90
Copy link
Contributor
@stnguyen90 stnguyen90 commented Jul 19, 2023 •
edited
Loading

What does this PR do?

Upgrade utopia-php/domain to fix some incorrect validation of domains.

Version 1.1.0 was an incorrectly named git tag that has been deleted; it was equivalent to 0.2.0.

image

This bump to 0.3.* is safe because it adds Registrar, but it won't be used in Appwrite yet. Bumping to 0.3.* is necessary to fix some bugs where valid domains were considered invalid.

Fixes #5317

Test Plan

Automated tests should pass.

Related PRs and Issues

Checklist

  • Have you read the Contributing Guidelines on issues?
  • If the PR includes a change to an API's metadata (desc, label, params, etc.), does it also include updated API specs and example docs?

@stnguyen90
Upgrade utopia-php/domains
803d653 
Version 1.1.0 was an incorrectly named git tag; it was equivalent to
0.2.0. This bump to 0.3.* is safe because it adds Registrar,
but it won't be used in Appwrite yet. Bumping to 0.3.* is necessary to
fix some bugs where valid domains were considered invalid.
@stnguyen90 stnguyen90 changed the title Upgrade utopia-php/domains Fix np TLD validation Jul 19, 2023
@stnguyen90 stnguyen90 mentioned this pull request Jul 20, 2023
Closed
2 tasks
@stnguyen90
Copy link
Contributor Author

Tests passed locally:
image

@stnguyen90 stnguyen90 requested a review from eldadfux July 20, 2023 04:37
@stnguyen90 stnguyen90 marked this pull request as ready for review July 20, 2023 04:38
@eldadfux eldadfux merged commit 30fc565 into master Jul 20, 2023
@stnguyen90 stnguyen90 deleted the chore-upgrade-domains branch July 20, 2023 07:33
This was referenced Aug 1, 2023
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@eldadfux eldadfux eldadfux approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

🐛 Bug Report: Country tld for .np is not supported
2 participants
@stnguyen90 @eldadfux
0