Create a dedicated upgrade command #5860
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Before, we used the same command for both installation and upgrades. This lead to problems because developers would try to upgrade in the wrong folder and end up creating a new installation. This new upgrade command validates the existence of an existing installation before proceeding with the upgrade to ensure no new installation is created when upgrading.
8bbe26b to
ffea39c
Compare
eldadfux
reviewed
Jul 22, 2023
There was a problem hiding this comment.
@stnguyen90 this is not exactly how we use class based tasks, we've created a new abstraction layer for them here: https://github.com/appwrite/cloud/tree/feat-billing/src/Appwrite/Cloud/Platform/Tasks we might be able to reuse this logic as we need to rewrite them anyway.
Please check with @lohanidamodar if we can adapt this approach here.
gewenyu99
suggested changes
Jul 24, 2023
| if (empty($data)) { | ||
| Console::error('Appwrite installation not found.'); | ||
| Console::log('The command was not run in the parent folder of your appwrite installation.'); | ||
| Console::log('Please navigate to the parent of the Appwrite installation and try again.'); |
There was a problem hiding this comment.
Suggested change
| Console::log('Please navigate to the parent of the Appwrite installation and try again.'); | |
| Console::log('Please navigate to the parent directory of the Appwrite installation and try again.'); |
|
Need to restructure the task. |
This was referenced Aug 1, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Before, we used the same command for both installation and upgrades. This lead to problems because developers would try to upgrade in the wrong folder and end up creating a new installation.
This new upgrade command validates the existence of an existing installation before proceeding with the upgrade to ensure no new installation is created when upgrading.
Test Plan
The following screenshot shows:
Latest error output:
Related PRs and Issues
Checklist