Feat upgrade task #5874
Merged
Feat upgrade task #5874
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This makes it so the property can be used by subclasses.
Before, we used the same command for both installation and upgrades. This lead to problems because developers would try to upgrade in the wrong folder and end up creating a new installation. This new upgrade command validates the existence of an existing installation before proceeding with the upgrade to ensure no new installation is created when upgrading.
5a3cf22 to
d8ea72b
Compare
eldadfux
reviewed
Jul 25, 2023
eldadfux
reviewed
Jul 25, 2023
eldadfux
approved these changes
Jul 26, 2023
lohanidamodar
approved these changes
Jul 26, 2023
This was referenced Aug 1, 2023
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Before, we used the same command for both installation and upgrades. This led to problems because developers would try to upgrade in the wrong folder and end up creating a new installation.
This new upgrade command validates the existence of an existing installation before proceeding with the upgrade to ensure no new installation is created when upgrading.
Test Plan
The following screenshot shows:
Running the upgrade command w/o an installation results in an error:
Installation still works:
Upgrading with an existing installation:
Related PRs and Issues
Checklist