8000 Ensure deletes worker deletes resources using internal id by stnguyen90 · Pull Request #5833 · appwrite/appwrite · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Ensure deletes worker deletes resources using internal id #5833

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jul 20, 2023
Merged

Ensure deletes worker deletes resources using internal id #5833

merged 2 commits into from
Jul 20, 2023

Conversation

stnguyen90
Copy link
Contributor
@stnguyen90 stnguyen90 commented Jul 18, 2023 •
edited
Loading

What does this PR do?

Ensure resources are deleted using their internal Id

This is necessary because a resource can be re-created with
the same id. If we don't use the internal id, the newer
recreated resource can be deleted.

Test Plan

Manual

Related PRs and Issues

None

Checklist

  • Have you read the Contributing Guidelines on issues?
  • If the PR includes a change to an API's metadata (desc, label, params, etc.), does it also include updated API specs and example docs?

@stnguyen90 stnguyen90 changed the base branch from master to feat-db-pools-master July 18, 2023 00:08
@stnguyen90 stnguyen90 marked this pull request as ready for review July 18, 2023 00:13
@stnguyen90 stnguyen90 force-pushed the fix-deletes-worker-internal-ids branch from e3f07d5 to d89469c Compare July 18, 2023 00:18
@stnguyen90
Fix team delete
fce230d 
Ensure all memberships are deleted and the cached users are
invalidated so that the nested memberships will refresh.
@stnguyen90
Ensure resources are deleted using their internal Id
308c92f 
This is necessary because a resource can be re-created with
the same id. If we don't use the internal id, the newer
recreated resource can be deleted.
@stnguyen90 stnguyen90 force-pushed the fix-deletes-worker-internal-ids branch from d89469c to 308c92f Compare July 18, 2023 00:21
@stnguyen90 stnguyen90 changed the title Fix deletes worker internal ids Ensure deletes worker deletes resources using internal id Jul 18, 2023
@eldadfux eldadfux merged commit 5b2dab2 into feat-db-pools-master Jul 20, 2023
@stnguyen90 stnguyen90 deleted the fix-deletes-worker-internal-ids branch July 20, 2023 07:33
This was referenced Aug 1, 2023
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@eldadfux eldadfux eldadfux approved these changes

@TorstenDittmann TorstenDittmann Awaiting requested review from TorstenDittmann

@christyjacob4 christyjacob4 Awaiting requested review from christyjacob4

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@stnguyen90 @eldadfux
0